You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/25 09:06:13 UTC
[GitHub] [dubbo-go-samples] jack15083 opened a new pull request #208: Add apollo config center sample
jack15083 opened a new pull request #208:
URL: https://github.com/apache/dubbo-go-samples/pull/208
Add apollo config center sample
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #208: Add apollo config center sample
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #208:
URL: https://github.com/apache/dubbo-go-samples/pull/208#discussion_r696202491
##########
File path: configcenter/apollo/README.md
##########
@@ -0,0 +1,55 @@
+# Apollo config center example
+
+## Instructions
+
+### go-server start
+1. Create new apollo server namespace for yaml format
+2. Add provider config content
+```yaml
+dubbo:
+ application:
+ name: "demo-server"
+ version: "2.0"
+ registries:
+ "demoZK":
+ protocol: "zookeeper"
+ timeout: "3s"
+ address: "127.0.0.1:2181"
+ protocols:
+ "triple":
+ name: "tri"
+ port: 20000
+ provider:
+ registry:
+ - demoZK
+ services:
+ "greeterImpl":
+ protocol: "triple"
+ interface: "com.apache.dubbo.sample.basic.IGreeter" # must be compatible with grpc or dubbo-java
+```
+3. Start provider server
Review comment:
在上面加上空行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin merged pull request #208: Add apollo config center sample
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #208:
URL: https://github.com/apache/dubbo-go-samples/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #208: Add apollo config center sample
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #208:
URL: https://github.com/apache/dubbo-go-samples/pull/208#discussion_r696202436
##########
File path: configcenter/apollo/README.md
##########
@@ -0,0 +1,55 @@
+# Apollo config center example
+
+## Instructions
+
+### go-server start
+1. Create new apollo server namespace for yaml format
+2. Add provider config content
Review comment:
在下面加上空行。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on pull request #208: Add apollo config center sample
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #208:
URL: https://github.com/apache/dubbo-go-samples/pull/208#issuecomment-905449125
增加一个goland启动项目
看到你的改动中把集成测试依赖的几个文件删了。但为啥没有放到integrate_test/对应目录下。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #208: Add apollo config center sample
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #208:
URL: https://github.com/apache/dubbo-go-samples/pull/208#discussion_r696202781
##########
File path: configcenter/apollo/README_zh.md
##########
@@ -0,0 +1,50 @@
+# Apollo 配置中心示例
Review comment:
如同英文文档，该加的空行都加上。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #208: Add apollo config center sample
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #208:
URL: https://github.com/apache/dubbo-go-samples/pull/208#discussion_r696202384
##########
File path: configcenter/apollo/README.md
##########
@@ -0,0 +1,55 @@
+# Apollo config center example
+
+## Instructions
+
+### go-server start
Review comment:
这markdown文档写的太密集了。在这里加上空行。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #208: Add apollo config center sample
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #208:
URL: https://github.com/apache/dubbo-go-samples/pull/208#discussion_r696202569
##########
File path: configcenter/apollo/README.md
##########
@@ -0,0 +1,55 @@
+# Apollo config center example
+
+## Instructions
+
+### go-server start
+1. Create new apollo server namespace for yaml format
+2. Add provider config content
+```yaml
+dubbo:
+ application:
+ name: "demo-server"
+ version: "2.0"
+ registries:
+ "demoZK":
+ protocol: "zookeeper"
+ timeout: "3s"
+ address: "127.0.0.1:2181"
+ protocols:
+ "triple":
+ name: "tri"
+ port: 20000
+ provider:
+ registry:
+ - demoZK
+ services:
+ "greeterImpl":
+ protocol: "triple"
+ interface: "com.apache.dubbo.sample.basic.IGreeter" # must be compatible with grpc or dubbo-java
+```
+3. Start provider server
+
+### go-client start
+1. Create new apollo client namespace for yaml format
+2. Add client config content
+```yaml
Review comment:
在上面加上空行
##########
File path: configcenter/apollo/README.md
##########
@@ -0,0 +1,55 @@
+# Apollo config center example
+
+## Instructions
+
+### go-server start
+1. Create new apollo server namespace for yaml format
+2. Add provider config content
+```yaml
+dubbo:
+ application:
+ name: "demo-server"
+ version: "2.0"
+ registries:
+ "demoZK":
+ protocol: "zookeeper"
+ timeout: "3s"
+ address: "127.0.0.1:2181"
+ protocols:
+ "triple":
+ name: "tri"
+ port: 20000
+ provider:
+ registry:
+ - demoZK
+ services:
+ "greeterImpl":
+ protocol: "triple"
+ interface: "com.apache.dubbo.sample.basic.IGreeter" # must be compatible with grpc or dubbo-java
+```
+3. Start provider server
+
+### go-client start
Review comment:
在下面加上空行
##########
File path: configcenter/apollo/README.md
##########
@@ -0,0 +1,55 @@
+# Apollo config center example
+
+## Instructions
+
+### go-server start
+1. Create new apollo server namespace for yaml format
+2. Add provider config content
+```yaml
+dubbo:
+ application:
+ name: "demo-server"
+ version: "2.0"
+ registries:
+ "demoZK":
+ protocol: "zookeeper"
+ timeout: "3s"
+ address: "127.0.0.1:2181"
+ protocols:
+ "triple":
+ name: "tri"
+ port: 20000
+ provider:
+ registry:
+ - demoZK
+ services:
+ "greeterImpl":
+ protocol: "triple"
+ interface: "com.apache.dubbo.sample.basic.IGreeter" # must be compatible with grpc or dubbo-java
+```
+3. Start provider server
+
+### go-client start
+1. Create new apollo client namespace for yaml format
+2. Add client config content
+```yaml
+dubbo:
+ registries:
+ "demoZK":
+ protocol: "zookeeper"
+ timeout: "3s"
+ address: "127.0.0.1:2181"
+ consumer:
+ registry:
+ - demoZK
+ references:
+ "greeterImpl":
+ protocol: "tri"
+ interface: "com.apache.dubbo.sample.basic.IGreeter" # must be compatible with grpc or dubbo-java
+```
+3. Start provider server
Review comment:
在上面加上空行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] jack15083 commented on pull request #208: Add apollo config center sample
Posted by GitBox <gi...@apache.org>.
jack15083 commented on pull request #208:
URL: https://github.com/apache/dubbo-go-samples/pull/208#issuecomment-906070136
> 增加一个goland启动项目
> 看到你的改动中把集成测试依赖的几个文件删了。但为啥没有放到integrate_test/对应目录下。
已添加
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org