You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/28 08:36:51 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #24173: [SPARK-27237][SS] Introduce State schema validation among query restart

MaxGekk commented on a change in pull request #24173:
URL: https://github.com/apache/spark/pull/24173#discussion_r775788368



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
##########
@@ -753,6 +755,89 @@ class StreamingAggregationSuite extends StateStoreMetricsTest with Assertions {
     )
   }
 
+  testQuietlyWithAllStateVersions("changing schema of state when restarting query",

Review comment:
       @HeartSaVioR FYI, the test is flaky. It fails sometimes in my PRs:
   ```
   [info] - changing schema of state when restarting query - state format version 1 *** FAILED *** (915 milliseconds)
   [info]   Error while checking stream failure: stateSchemaExc.isDefined was false
   [info]   org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
   [info]   	org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
   [info]   	org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org