[jclouds-karaf] JCLOUDS-635 Always check for container existence before uploading blobs. (#50)

[Shri Javadekar <no...@github.com>]

This guarantees that the same error code is returned for all cloud providers
if the container does not exist.

Fixes #635.
You can merge this Pull Request by running:

  git pull https://github.com/maginatics/jclouds-karaf fix_jclouds_635

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-karaf/pull/50

-- Commit Summary --

  * JCLOUDS-635 Always check for container existence before uploading blobs.

-- File Changes --

    M commands/src/main/java/org/jclouds/karaf/commands/blobstore/BlobStoreCommandBase.java (5)

-- Patch Links --

https://github.com/jclouds/jclouds-karaf/pull/50.patch
https://github.com/jclouds/jclouds-karaf/pull/50.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/50

Re: [jclouds-karaf] JCLOUDS-635 Always check for container existence before uploading blobs. (#50)

[CloudBees pull request builder plugin <no...@github.com>]

[jclouds-karaf-pull-requests #81](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/81/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/50#issuecomment-49917581

Re: [jclouds-karaf] JCLOUDS-635 Always check for container existence before uploading blobs. (#50)

[Andrew Gaul <no...@github.com>]

> @@ -155,6 +155,11 @@ protected Configuration findOrCreateFactoryConfiguration(ConfigurationAdmin conf
>      * @param options
>      */
>     public void write(BlobStore blobStore, String bucket, String blobName, Blob blob, PutOptions options, boolean signedRequest) throws Exception {
> +      if (!blobStore.containerExists(bucket)) {

This is a big hammer to solve a small problem: all write commands will require two RPCs even in the case of when the container exists and for non-Swift blobstores.  Can we do something better than this, possibly in the Swift provider itself?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/50/files#r15309418

Re: [jclouds-karaf] JCLOUDS-635 Always check for container existence before uploading blobs. (#50)

[Everett Toews <no...@github.com>]

Thanks for the pull request but it's release week in jclouds and that means it's time to clean up the PR queue. This PR will be over 6 months old as of April 1. If you intend to continue work on it, please make a comment by April 2. Otherwise it will be closed on April 3.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/50#issuecomment-85718919

Re: [jclouds-karaf] JCLOUDS-635 Always check for container existence before uploading blobs. (#50)

[BuildHive <no...@github.com>]

[jclouds » jclouds-karaf #1146](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/1146/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/50#issuecomment-49924955

Re: [jclouds-karaf] JCLOUDS-635 Always check for container existence before uploading blobs. (#50)

[Andrew Gaul <no...@github.com>]

We should not address this with hacks in karaf.  We have a bunch of JIRA issues tracking these and should address it in core:

https://issues.apache.org/jira/browse/JCLOUDS-193
https://issues.apache.org/jira/browse/JCLOUDS-635
https://issues.apache.org/jira/browse/JCLOUDS-648
https://issues.apache.org/jira/browse/JCLOUDS-650

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/50#issuecomment-85719716