You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2024/06/08 00:05:01 UTC
Review Request 75039: RANGER-4815: removed trino-shim as Trino already uses classloader to isolate plugin libraries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75039/
-----------------------------------------------------------
Review request for ranger, Abhishek Patil, Abhishek Kumar, Asit Vadhavkar, Fateh Singh, Abhay Kulkarni, Mugdha Varadkar, Pradeep Agrawal, Ramesh Mani, and Sailaja Polavarapu.
Bugs: RANGER-4815
https://issues.apache.org/jira/browse/RANGER-4815
Repository: ranger
Description
-------
- removed ranger-trino-plugin-shim project
- updated plugin-trino so that Trino can load the authorizer implementation
- updated distro and setup script for the changes in the packaging
Diffs
-----
distro/src/main/assembly/plugin-trino.xml 678dd818a
plugin-trino/pom.xml 214710acc
plugin-trino/scripts/enable-trino-plugin.sh PRE-CREATION
plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 6ba0e2265
plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlTest.java af97093ef
pom.xml efd152040
ranger-trino-plugin-shim/.gitignore b83d22266
ranger-trino-plugin-shim/pom.xml 9982a22cf
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerConfig.java
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 33becc13d
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlFactory.java
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/TrinoRangerPlugin.java
ranger-trino-plugin-shim/src/main/resources/META-INF/services/io.trino.spi.Plugin
Diff: https://reviews.apache.org/r/75039/diff/1/
Testing
-------
Verified the following using docker setup:
- Trino plugin installs and loads successfully
- Trino plugin enforces policies defined in Ranger
Thanks,
Madhan Neethiraj
Re: Review Request 75039: RANGER-4815: removed trino-shim as Trino already uses classloader to isolate plugin libraries
Posted by Ramesh Mani <rm...@hortonworks.com>.
> On June 8, 2024, 5:27 p.m., Ramesh Mani wrote:
> > distro/src/main/assembly/plugin-trino.xml
> > Line 204 (original), 188 (patched)
> > <https://reviews.apache.org/r/75039/diff/1/?file=2288669#file2288669line206>
> >
> > Does the upgrade scenario needs to be taken care to remove the old jars?
>
> Madhan Neethiraj wrote:
> For upgrade, new version bits will be installed in a separate directory, right?
Madhan, yes you are right. Old file gets moved and new directory and symlinks are created.
- Ramesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75039/#review226529
-----------------------------------------------------------
On June 8, 2024, 12:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75039/
> -----------------------------------------------------------
>
> (Updated June 8, 2024, 12:04 a.m.)
>
>
> Review request for ranger, Abhishek Patil, Abhishek Kumar, Asit Vadhavkar, Fateh Singh, Abhay Kulkarni, Mugdha Varadkar, Pradeep Agrawal, Ramesh Mani, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-4815
> https://issues.apache.org/jira/browse/RANGER-4815
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - removed ranger-trino-plugin-shim project
> - updated plugin-trino so that Trino can load the authorizer implementation
> - updated distro and setup script for the changes in the packaging
>
>
> Diffs
> -----
>
> distro/src/main/assembly/plugin-trino.xml 678dd818a
> plugin-trino/pom.xml 214710acc
> plugin-trino/scripts/enable-trino-plugin.sh PRE-CREATION
> plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 6ba0e2265
> plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlTest.java af97093ef
> pom.xml efd152040
> ranger-trino-plugin-shim/.gitignore b83d22266
> ranger-trino-plugin-shim/pom.xml 9982a22cf
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerConfig.java
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 33becc13d
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlFactory.java
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/TrinoRangerPlugin.java
> ranger-trino-plugin-shim/src/main/resources/META-INF/services/io.trino.spi.Plugin
>
>
> Diff: https://reviews.apache.org/r/75039/diff/1/
>
>
> Testing
> -------
>
> Verified the following using docker setup:
> - Trino plugin installs and loads successfully
> - Trino plugin enforces policies defined in Ranger
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 75039: RANGER-4815: removed trino-shim as Trino already uses classloader to isolate plugin libraries
Posted by Madhan Neethiraj <ma...@apache.org>.
> On June 8, 2024, 5:27 p.m., Ramesh Mani wrote:
> > distro/src/main/assembly/plugin-trino.xml
> > Line 204 (original), 188 (patched)
> > <https://reviews.apache.org/r/75039/diff/1/?file=2288669#file2288669line206>
> >
> > Does the upgrade scenario needs to be taken care to remove the old jars?
For upgrade, new version bits will be installed in a separate directory, right?
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75039/#review226529
-----------------------------------------------------------
On June 8, 2024, 12:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75039/
> -----------------------------------------------------------
>
> (Updated June 8, 2024, 12:04 a.m.)
>
>
> Review request for ranger, Abhishek Patil, Abhishek Kumar, Asit Vadhavkar, Fateh Singh, Abhay Kulkarni, Mugdha Varadkar, Pradeep Agrawal, Ramesh Mani, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-4815
> https://issues.apache.org/jira/browse/RANGER-4815
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - removed ranger-trino-plugin-shim project
> - updated plugin-trino so that Trino can load the authorizer implementation
> - updated distro and setup script for the changes in the packaging
>
>
> Diffs
> -----
>
> distro/src/main/assembly/plugin-trino.xml 678dd818a
> plugin-trino/pom.xml 214710acc
> plugin-trino/scripts/enable-trino-plugin.sh PRE-CREATION
> plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 6ba0e2265
> plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlTest.java af97093ef
> pom.xml efd152040
> ranger-trino-plugin-shim/.gitignore b83d22266
> ranger-trino-plugin-shim/pom.xml 9982a22cf
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerConfig.java
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 33becc13d
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlFactory.java
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/TrinoRangerPlugin.java
> ranger-trino-plugin-shim/src/main/resources/META-INF/services/io.trino.spi.Plugin
>
>
> Diff: https://reviews.apache.org/r/75039/diff/1/
>
>
> Testing
> -------
>
> Verified the following using docker setup:
> - Trino plugin installs and loads successfully
> - Trino plugin enforces policies defined in Ranger
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 75039: RANGER-4815: removed trino-shim as Trino already uses classloader to isolate plugin libraries
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75039/#review226529
-----------------------------------------------------------
distro/src/main/assembly/plugin-trino.xml
Line 204 (original), 188 (patched)
<https://reviews.apache.org/r/75039/#comment314775>
Does the upgrade scenario needs to be taken care to remove the old jars?
- Ramesh Mani
On June 8, 2024, 12:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75039/
> -----------------------------------------------------------
>
> (Updated June 8, 2024, 12:04 a.m.)
>
>
> Review request for ranger, Abhishek Patil, Abhishek Kumar, Asit Vadhavkar, Fateh Singh, Abhay Kulkarni, Mugdha Varadkar, Pradeep Agrawal, Ramesh Mani, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-4815
> https://issues.apache.org/jira/browse/RANGER-4815
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - removed ranger-trino-plugin-shim project
> - updated plugin-trino so that Trino can load the authorizer implementation
> - updated distro and setup script for the changes in the packaging
>
>
> Diffs
> -----
>
> distro/src/main/assembly/plugin-trino.xml 678dd818a
> plugin-trino/pom.xml 214710acc
> plugin-trino/scripts/enable-trino-plugin.sh PRE-CREATION
> plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 6ba0e2265
> plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlTest.java af97093ef
> pom.xml efd152040
> ranger-trino-plugin-shim/.gitignore b83d22266
> ranger-trino-plugin-shim/pom.xml 9982a22cf
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerConfig.java
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 33becc13d
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlFactory.java
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/TrinoRangerPlugin.java
> ranger-trino-plugin-shim/src/main/resources/META-INF/services/io.trino.spi.Plugin
>
>
> Diff: https://reviews.apache.org/r/75039/diff/1/
>
>
> Testing
> -------
>
> Verified the following using docker setup:
> - Trino plugin installs and loads successfully
> - Trino plugin enforces policies defined in Ranger
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 75039: RANGER-4815: removed trino-shim as Trino already uses classloader to isolate plugin libraries
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75039/#review226532
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On June 8, 2024, 12:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75039/
> -----------------------------------------------------------
>
> (Updated June 8, 2024, 12:04 a.m.)
>
>
> Review request for ranger, Abhishek Patil, Abhishek Kumar, Asit Vadhavkar, Fateh Singh, Abhay Kulkarni, Mugdha Varadkar, Pradeep Agrawal, Ramesh Mani, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-4815
> https://issues.apache.org/jira/browse/RANGER-4815
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - removed ranger-trino-plugin-shim project
> - updated plugin-trino so that Trino can load the authorizer implementation
> - updated distro and setup script for the changes in the packaging
>
>
> Diffs
> -----
>
> distro/src/main/assembly/plugin-trino.xml 678dd818a
> plugin-trino/pom.xml 214710acc
> plugin-trino/scripts/enable-trino-plugin.sh PRE-CREATION
> plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 6ba0e2265
> plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlTest.java af97093ef
> pom.xml efd152040
> ranger-trino-plugin-shim/.gitignore b83d22266
> ranger-trino-plugin-shim/pom.xml 9982a22cf
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerConfig.java
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java 33becc13d
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlFactory.java
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/TrinoRangerPlugin.java
> ranger-trino-plugin-shim/src/main/resources/META-INF/services/io.trino.spi.Plugin
>
>
> Diff: https://reviews.apache.org/r/75039/diff/1/
>
>
> Testing
> -------
>
> Verified the following using docker setup:
> - Trino plugin installs and loads successfully
> - Trino plugin enforces policies defined in Ranger
>
>
> Thanks,
>
> Madhan Neethiraj
>
>