You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2023/10/16 21:53:10 UTC
[PR] GH-38297: [C#] Fix build for .NET 4.7.2 [arrow]
CurtHagenlocher opened a new pull request, #38299:
URL: https://github.com/apache/arrow/pull/38299
### What changes are included in this PR?
Fixes #38297
### Are these changes tested?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38297: [C#] Fix build for .NET 4.7.2 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38299:
URL: https://github.com/apache/arrow/pull/38299#issuecomment-1765445397
We may need to create a document for new committer in https://arrow.apache.org/docs/ instead of using `dev/README.md`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38297: [C#] Fix build for .NET 4.7.2 [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #38299:
URL: https://github.com/apache/arrow/pull/38299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38297: [C#] Fix build for .NET 4.7.2 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38299:
URL: https://github.com/apache/arrow/pull/38299#issuecomment-1765433483
@CurtHagenlocher Could you use our merge script instead of the GitHub's merge button?
https://github.com/apache/arrow/tree/main/dev#how-to-merge-a-pull-request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38297: [C#] Fix build for .NET 4.7.2 [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #38299:
URL: https://github.com/apache/arrow/pull/38299#issuecomment-1765399631
As these are trivial changes aimed at fixing the build, I'm going to check in the changes without additional review and ask for forgiveness if required... .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38297: [C#] Fix build for .NET 4.7.2 [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #38299:
URL: https://github.com/apache/arrow/pull/38299#issuecomment-1765443364
Oops, sorry :(. Guess I didn't read nearly enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38297: [C#] Fix build for .NET 4.7.2 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38299:
URL: https://github.com/apache/arrow/pull/38299#issuecomment-1770023584
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 71a76c340c6dfe1fcde51b22f718a26da4edd7bc.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17847423454) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org