You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/02/16 00:19:05 UTC
[kudu-CR] [schema] use operator==() instead of Equals()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18237
Change subject: [schema] use operator==() instead of Equals()
......................................................................
[schema] use operator==() instead of Equals()
While looking at the code in src/kudu/common/schema.h in the scope of
reviewing a prior changelist, I noticed that the comparison options
for Schema::Equals() were used only in the test scenarios. I took
the liberty and moved the Equals() method into the test code and
replaced it with the operator== at call sites. This patch includes
other minor cleanup, but overall the patch doesn't contain any
functional changes.
Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb
---
M src/kudu/client/client.cc
M src/kudu/client/schema.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/row.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/master-test.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tserver/tablet_service.cc
13 files changed, 99 insertions(+), 81 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/18237/1
--
To view, visit http://gerrit.cloudera.org:8080/18237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [schema] use operator==() instead of Equals()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18237 )
Change subject: [schema] use operator==() instead of Equals()
......................................................................
[schema] use operator==() instead of Equals()
While looking at the code in src/kudu/common/schema.h in the scope of
reviewing a prior changelist, I noticed that the comparison options
for Schema::Equals() were used only in the test scenarios. I took
the liberty and moved the Equals() method into the test code and
replaced it with the operator== at call sites. This patch includes
other minor cleanup, but overall the patch doesn't contain any
functional changes.
Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb
Reviewed-on: http://gerrit.cloudera.org:8080/18237
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/client.cc
M src/kudu/client/schema.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/row.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/master-test.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tserver/tablet_service.cc
13 files changed, 99 insertions(+), 81 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [schema] use operator==() instead of Equals()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18237 )
Change subject: [schema] use operator==() instead of Equals()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18237/1/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/18237/1/src/kudu/master/master-test.cc@1401
PS1, Line 1401: CHECK(kTableSch
nit: CHECK_EQ?
--
To view, visit http://gerrit.cloudera.org:8080/18237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Feb 2022 17:56:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [schema] use operator==() instead of Equals()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [schema] use operator==() instead of Equals()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [schema] use operator==() instead of Equals()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18237 )
Change subject: [schema] use operator==() instead of Equals()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18237/1/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/18237/1/src/kudu/master/master-test.cc@1401
PS1, Line 1401: CHECK(kTableSch
> nit: CHECK_EQ?
Yeah, I tried that -- unfortunately, CHECK_EQ() requires proper ostream output iterator or method defined for Schema. I decided to not introduce that, so opted for CHECK() here instead.
--
To view, visit http://gerrit.cloudera.org:8080/18237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Feb 2022 21:24:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [schema] use operator==() instead of Equals()
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18237 )
Change subject: [schema] use operator==() instead of Equals()
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Feb 2022 16:15:01 +0000
Gerrit-HasComments: No
[kudu-CR] [schema] use operator==() instead of Equals()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18237 )
Change subject: [schema] use operator==() instead of Equals()
......................................................................
Patch Set 1: Verified+1
Unrelated test failure in AdminCliTest.TestExtraConfig
SIGSEGV somewhere in tcmalloc::ThreadCache::ReleaseToCentralCache() upon exiting
--
To view, visit http://gerrit.cloudera.org:8080/18237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0e3d75d216241efec49b64233198eafe52871cb
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Feb 2022 02:24:04 +0000
Gerrit-HasComments: No