You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/10 10:13:19 UTC

[GitHub] [maven-site] kwin opened a new pull request, #326: [MNGSITE-496] Outline all means to load extensions and clarify

kwin opened a new pull request, #326:
URL: https://github.com/apache/maven-site/pull/326

   differences


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] cstamas commented on pull request #326: [MNGSITE-496] Outline all means to load extensions and clarify

Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #326:
URL: https://github.com/apache/maven-site/pull/326#issuecomment-1275897115

   Maybe state clearly that [afterSessionStart](https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/AbstractMavenLifecycleParticipant.java#L63) does NOT work in "late" mode for obvious reasons.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] kwin merged pull request #326: [MNGSITE-496] Outline all means to load extensions and clarify

Posted by GitBox <gi...@apache.org>.
kwin merged PR #326:
URL: https://github.com/apache/maven-site/pull/326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] cstamas commented on pull request #326: [MNGSITE-496] Outline all means to load extensions and clarify

Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #326:
URL: https://github.com/apache/maven-site/pull/326#issuecomment-1275922609

   oh, i missed those, sorry (I hate archaic APT format). Yes, is important for ext authors, not much for consumers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] kwin commented on pull request #326: [MNGSITE-496] Outline all means to load extensions and clarify

Posted by GitBox <gi...@apache.org>.
kwin commented on PR #326:
URL: https://github.com/apache/maven-site/pull/326#issuecomment-1275901382

   > Maybe state clearly that [afterSessionStart](https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/AbstractMavenLifecycleParticipant.java#L63) does NOT work in "late" mode for obvious reasons.
   
   Is that not clear enough: https://github.com/apache/maven-site/pull/326/files#diff-d57f2ffce98d7dc59a0359835112b62a6bb7213f279eae4c60f67a6a9ef5638fR125? For me that is an aspect for extension writers and not so much for extension consumers?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] kwin commented on pull request #326: [MNGSITE-496] Outline all means to load extensions and clarify

Posted by GitBox <gi...@apache.org>.
kwin commented on PR #326:
URL: https://github.com/apache/maven-site/pull/326#issuecomment-1275899778

   > But POM has extensions element as well https://maven.apache.org/pom.html#Extensions
   
   I think I mentioned those at https://github.com/apache/maven-site/pull/326/files#diff-bcbf6d6b4afe0d44d1c378f922812615b44429cb439b08fcb503e47446c138f4R83.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org