You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Shoothzj (via GitHub)" <gi...@apache.org> on 2023/05/30 03:32:30 UTC

[GitHub] [pulsar-client-cpp] Shoothzj opened a new pull request, #275: add cmake-build-debug dir to gitignore

Shoothzj opened a new pull request, #275:
URL: https://github.com/apache/pulsar-client-cpp/pull/275

   ### Motivation
   add cmake-build-debug dir to gitignore. It shouldn't committed to the repo
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #275: add cmake-build-debug dir to gitignore

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on code in PR #275:
URL: https://github.com/apache/pulsar-client-cpp/pull/275#discussion_r1209819918


##########
.gitignore:
##########
@@ -83,6 +83,7 @@ Makefile
 cmake_install.cmake
 CMakeFiles
 CMakeCache.txt
+/cmake-build-debug

Review Comment:
   Should we change it to `./cmake-build-debug`? And CMake can specifiy an arbitrary build directory. For example, the command `cmake -B build` will create a `build` directory to contain CMake build files.
   
   Though it makes sense if `cmake-build-debug` is generated by a specific IDE by default. For example, Visual Studio creates `out/` directory as the build directory. If then, please add a comment to explain.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] Shoothzj commented on a diff in pull request #275: add cmake-build-debug dir to gitignore

Posted by "Shoothzj (via GitHub)" <gi...@apache.org>.
Shoothzj commented on code in PR #275:
URL: https://github.com/apache/pulsar-client-cpp/pull/275#discussion_r1209850860


##########
.gitignore:
##########
@@ -83,6 +83,7 @@ Makefile
 cmake_install.cmake
 CMakeFiles
 CMakeCache.txt
+/cmake-build-debug

Review Comment:
   @BewareMyPower what's the difference between `./cmake-build-debug` and `/cmake-build-debug`. I don't see the difference



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #275: add cmake-build-debug dir to gitignore

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower merged PR #275:
URL: https://github.com/apache/pulsar-client-cpp/pull/275


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] Shoothzj commented on pull request #275: add cmake-build-debug dir to gitignore

Posted by "Shoothzj (via GitHub)" <gi...@apache.org>.
Shoothzj commented on PR #275:
URL: https://github.com/apache/pulsar-client-cpp/pull/275#issuecomment-1568004730

   @BewareMyPower @RobertIndie I think we can merge this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] Shoothzj commented on a diff in pull request #275: add cmake-build-debug dir to gitignore

Posted by "Shoothzj (via GitHub)" <gi...@apache.org>.
Shoothzj commented on code in PR #275:
URL: https://github.com/apache/pulsar-client-cpp/pull/275#discussion_r1209856451


##########
.gitignore:
##########
@@ -83,6 +83,7 @@ Makefile
 cmake_install.cmake
 CMakeFiles
 CMakeCache.txt
+/cmake-build-debug

Review Comment:
   @BewareMyPower I have done add c comment this dir is generated by clion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] Shoothzj commented on a diff in pull request #275: add cmake-build-debug dir to gitignore

Posted by "Shoothzj (via GitHub)" <gi...@apache.org>.
Shoothzj commented on code in PR #275:
URL: https://github.com/apache/pulsar-client-cpp/pull/275#discussion_r1209925237


##########
.gitignore:
##########
@@ -83,6 +83,8 @@ Makefile
 cmake_install.cmake
 CMakeFiles
 CMakeCache.txt
+# cmake files generated by CLion
+/cmake-build-debug

Review Comment:
   @RobertIndie Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] RobertIndie commented on a diff in pull request #275: add cmake-build-debug dir to gitignore

Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on code in PR #275:
URL: https://github.com/apache/pulsar-client-cpp/pull/275#discussion_r1209901730


##########
.gitignore:
##########
@@ -83,6 +83,8 @@ Makefile
 cmake_install.cmake
 CMakeFiles
 CMakeCache.txt
+# cmake files generated by CLion
+/cmake-build-debug

Review Comment:
   It's better to use `/cmake-build-*` just like what JetBrains suggested: 
   https://github.com/github/gitignore/blob/4488915eec0b3a45b5c63ead28f286819c0917de/Global/JetBrains.gitignore#L43-L44



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org