You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by karensmolermiller <gi...@git.apache.org> on 2017/05/26 19:05:47 UTC
[GitHub] geode pull request #543: GEODE-2957 gfsh create lucene index "null" becomes ...
GitHub user karensmolermiller opened a pull request:
https://github.com/apache/geode/pull/543
GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT"
@DivineEnder @nabarunnag @ladyVader @boglesby @joeymcallister @davebarnes97
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2957
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/543.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #543
----
commit fd7dfd0f61f8e46ff8b3a157ffa8f8dacdf74d31
Author: Karen Miller <km...@pivotal.io>
Date: 2017-05-26T18:57:49Z
GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #543: GEODE-2957 gfsh create lucene index "null" becomes ...
Posted by karensmolermiller <gi...@git.apache.org>.
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/543#discussion_r119231641
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName --region=/orders --field=customer,tags
``` pre
// Create an index, specifying a custom analyzer for the second field
-// Note: "null" in the first analyzer position uses the default analyzer
+// Note: "DEFAULT" in the first analyzer position uses the default analyzer
// for the first field
gfsh>create lucene index --name=indexName --region=/orders
- --field=customer,tags --analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer
+ --field=customer,tags --analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer
```
To use the entire value as a single field set the required `--field`
--- End diff --
The sentence that needs the comma has been completely rewritten for GEODE-3002. See PR https://github.com/apache/geode/pull/550 for the rewrite. Not implementing, as it would only cause a conflict upon merging in GEODE-3002.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #543: GEODE-2957 gfsh create lucene index "null" becomes ...
Posted by joeymcallister <gi...@git.apache.org>.
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/543#discussion_r119232692
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName --region=/orders --field=customer,tags
``` pre
// Create an index, specifying a custom analyzer for the second field
-// Note: "null" in the first analyzer position uses the default analyzer
+// Note: "DEFAULT" in the first analyzer position uses the default analyzer
// for the first field
gfsh>create lucene index --name=indexName --region=/orders
- --field=customer,tags --analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer
+ --field=customer,tags --analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer
```
To use the entire value as a single field set the required `--field`
--- End diff --
Cool. LGTM, then. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #543: GEODE-2957 gfsh create lucene index "null" becomes "DEFAUL...
Posted by DivineEnder <gi...@git.apache.org>.
Github user DivineEnder commented on the issue:
https://github.com/apache/geode/pull/543
Looks good 👍
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #543: GEODE-2957 gfsh create lucene index "null" becomes ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/543
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #543: GEODE-2957 gfsh create lucene index "null" becomes "DEFAUL...
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on the issue:
https://github.com/apache/geode/pull/543
I will be merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #543: GEODE-2957 gfsh create lucene index "null" becomes ...
Posted by joeymcallister <gi...@git.apache.org>.
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/543#discussion_r119218480
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName --region=/orders --field=customer,tags
``` pre
// Create an index, specifying a custom analyzer for the second field
-// Note: "null" in the first analyzer position uses the default analyzer
+// Note: "DEFAULT" in the first analyzer position uses the default analyzer
// for the first field
gfsh>create lucene index --name=indexName --region=/orders
- --field=customer,tags --analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer
+ --field=customer,tags --analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer
```
To use the entire value as a single field set the required `--field`
--- End diff --
Add a comma between "field" and "set"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---