You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2025/02/24 11:32:44 UTC
[I] [C++] Build REE and decode functions uncoditionally of ARROW_COMPUTE=ON/OFF [arrow]
raulcd opened a new issue, #45610:
URL: https://github.com/apache/arrow/issues/45610
### Describe the enhancement requested
I am investigating how we build the compute kernels in order to try and split those into a separate shared object outside of `libarrow.so`
I've realized we build REE functions conditionally if `ARROW_COMPUTE=ON`. As this is part of the core format I think those should be built unconditionally same as other kernels like dictionary decode.
https://github.com/apache/arrow/blob/main/cpp/src/arrow/compute/registry.cc#L321-L322
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Build REE and decode functions uncoditionally of ARROW_COMPUTE=ON/OFF [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd closed issue #45610: [C++] Build REE and decode functions uncoditionally of ARROW_COMPUTE=ON/OFF
URL: https://github.com/apache/arrow/issues/45610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Build REE and decode functions uncoditionally of ARROW_COMPUTE=ON/OFF [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #45610:
URL: https://github.com/apache/arrow/issues/45610#issuecomment-2678284402
If it's only the tests and not the C bridge itself, then it probably doesn't matter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Build REE and decode functions uncoditionally of ARROW_COMPUTE=ON/OFF [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #45610:
URL: https://github.com/apache/arrow/issues/45610#issuecomment-2678153739
@pitrou what do you think? shouldn't this be the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Build REE and decode functions uncoditionally of ARROW_COMPUTE=ON/OFF [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #45610:
URL: https://github.com/apache/arrow/issues/45610#issuecomment-2678264913
Well, the "core kernels" are those that are required for core functionality such as the IPC layer. For example, dictionary decoding is necessary for processing delta dictionaries in IPC. As long as REE routines are not needed by any core component, they should probably not be included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Build REE and decode functions uncoditionally of ARROW_COMPUTE=ON/OFF [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #45610:
URL: https://github.com/apache/arrow/issues/45610#issuecomment-2678279648
ok, I'll take a look why then `arrow-c-bridge-tests` seem to require REE functions to be available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Build REE and decode functions uncoditionally of ARROW_COMPUTE=ON/OFF [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #45610:
URL: https://github.com/apache/arrow/issues/45610#issuecomment-2930835788
Closing this as it doesn't seem required and what should be done is covered here:
- https://github.com/apache/arrow/issues/37221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Build REE and decode functions uncoditionally of ARROW_COMPUTE=ON/OFF [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #45610:
URL: https://github.com/apache/arrow/issues/45610#issuecomment-2678266377
You might also want to measure the library size with and without those kernels, to get a better idea of how much including them would cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org