[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #671: Add case insensitive support to CachingCatalog

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #671: Add case insensitive support to CachingCatalog
URL: https://github.com/apache/incubator-iceberg/pull/671#discussion_r350073159
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/catalog/TableIdentifier.java
 ##########
 @@ -77,6 +77,14 @@ public String name() {
     return name;
   }
 
+  public TableIdentifier toLowerCase() {
+    String[] newLevels = Arrays.stream(namespace().levels())
+        .map(String::toLowerCase)
 
 Review comment:
   nit: Would it be a good idea to pass an explicit `Locale.ROOT` to `toLowerCase`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org