You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "SiyaoIsHiding (via GitHub)" <gi...@apache.org> on 2026/04/30 06:44:42 UTC
[PR] CASSJAVA-115: Java 25 support [cassandra-java-driver]
SiyaoIsHiding opened a new pull request, #2085:
URL: https://github.com/apache/cassandra-java-driver/pull/2085
Add Java 25 to DataStax CI. Adding Java 25 to ASF CI will be in another PR.
Attention needed on:
1. Dependency bumps on blockhound and jacoco
2. Java 25 [breaking change](https://github.com/openjdk/jdk/commit/8a4315f833f3700075d65fae6bc566011c837c07) on CompletableFuture.get()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-115: Java 25 support [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #2085:
URL: https://github.com/apache/cassandra-java-driver/pull/2085#issuecomment-5553203770
Jenkins run showed a reoccurence of the weirdness described in [CASSJAVA-138](https://issues.apache.org/jira/browse/CASSJAVA-138)... I've added a note there to document what I observed. But otherwise the test was clean.
@SiyaoIsHiding this should be ready to merge. Can you squash this down to a single commit and add the "patch by" line so that we can get this in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-115: Java 25 support [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce merged PR #2085:
URL: https://github.com/apache/cassandra-java-driver/pull/2085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-115: Java 25 support [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #2085:
URL: https://github.com/apache/cassandra-java-driver/pull/2085#issuecomment-5545973578
Looks about like what I'd expect @SiyaoIsHiding. I'm going to kick off a Jenkins run just to make sure nothing odd happens but if that's clean I'll argue we should just merge this. We'll need to resolve a few things against changes coming in CASSJAVA-135 but I can do that there just as easily as you can do it here... and I strongly suspect we'll be ready to merge this change before we're ready to merge CASSJAVA-135.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-115: Java 25 support [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #2085:
URL: https://github.com/apache/cassandra-java-driver/pull/2085#discussion_r3937584774
##########
pom.xml:
##########
@@ -1068,6 +1068,19 @@ limitations under the License.]]></inlineHeader>
<mockitoopens.argline>--add-opens=java.base/jdk.internal.util.random=ALL-UNNAMED</mockitoopens.argline>
</properties>
</profile>
+ <profile>
+ <!-- workarounds for running tests with JDK21 -->
+ <id>test-jdk-25</id>
+ <activation>
+ <jdk>[25,)</jdk>
+ </activation>
+ <properties>
+ <!-- for DriverBlockHoundIntegrationIT when using JDK 13+, see https://github.com/reactor/BlockHound/issues/33 -->
+ <blockhound.argline>-XX:+AllowRedefinitionToAddDeleteMethods</blockhound.argline>
+ <!-- allow deep reflection for mockito when using JDK 17+, see https://stackoverflow.com/questions/70993863/mockito-can-not-mock-random-in-java-17 -->
+ <mockitoopens.argline>--add-opens=java.base/jdk.internal.util.random=ALL-UNNAMED</mockitoopens.argline>
+ </properties>
+ </profile>
Review Comment:
I did away with the "test-jdk-X" blocks as part of the work on CASSJAVA-135. The blocks for all support JDK versions (Java17 and Java21 in that example) were identical so there wasn't really any need to keep it in place. These args match what will be [the defaults](https://github.com/apache/cassandra-java-driver/pull/2096/changes#r3827716324) once that PR is merged so this entire profile can just be deleted.
Side note: such a change also means this PR should be merged _after_ we get CASSJAVA-135 in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-115: Java 25 support [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #2085:
URL: https://github.com/apache/cassandra-java-driver/pull/2085#discussion_r3937584774
##########
pom.xml:
##########
@@ -1068,6 +1068,19 @@ limitations under the License.]]></inlineHeader>
<mockitoopens.argline>--add-opens=java.base/jdk.internal.util.random=ALL-UNNAMED</mockitoopens.argline>
</properties>
</profile>
+ <profile>
+ <!-- workarounds for running tests with JDK21 -->
+ <id>test-jdk-25</id>
+ <activation>
+ <jdk>[25,)</jdk>
+ </activation>
+ <properties>
+ <!-- for DriverBlockHoundIntegrationIT when using JDK 13+, see https://github.com/reactor/BlockHound/issues/33 -->
+ <blockhound.argline>-XX:+AllowRedefinitionToAddDeleteMethods</blockhound.argline>
+ <!-- allow deep reflection for mockito when using JDK 17+, see https://stackoverflow.com/questions/70993863/mockito-can-not-mock-random-in-java-17 -->
+ <mockitoopens.argline>--add-opens=java.base/jdk.internal.util.random=ALL-UNNAMED</mockitoopens.argline>
+ </properties>
+ </profile>
Review Comment:
I did away with the "test-jdk-X" blocks as part of the work on CASSJAVA-135. The blocks for all support JDK versions (Java17 and Java21 in that example) were identical so there wasn't really any need to keep it in place. These args match what will be the default arguments once that PR is merged so this entire profile can just be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-115: Java 25 support [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #2085:
URL: https://github.com/apache/cassandra-java-driver/pull/2085#discussion_r3937584774
##########
pom.xml:
##########
@@ -1068,6 +1068,19 @@ limitations under the License.]]></inlineHeader>
<mockitoopens.argline>--add-opens=java.base/jdk.internal.util.random=ALL-UNNAMED</mockitoopens.argline>
</properties>
</profile>
+ <profile>
+ <!-- workarounds for running tests with JDK21 -->
+ <id>test-jdk-25</id>
+ <activation>
+ <jdk>[25,)</jdk>
+ </activation>
+ <properties>
+ <!-- for DriverBlockHoundIntegrationIT when using JDK 13+, see https://github.com/reactor/BlockHound/issues/33 -->
+ <blockhound.argline>-XX:+AllowRedefinitionToAddDeleteMethods</blockhound.argline>
+ <!-- allow deep reflection for mockito when using JDK 17+, see https://stackoverflow.com/questions/70993863/mockito-can-not-mock-random-in-java-17 -->
+ <mockitoopens.argline>--add-opens=java.base/jdk.internal.util.random=ALL-UNNAMED</mockitoopens.argline>
+ </properties>
+ </profile>
Review Comment:
I did away with the "test-jdk-X" blocks as part of the work on CASSJAVA-135. The blocks for all support JDK versions (Java17 and Java21 in that example) were identical so there wasn't really any need to keep it in place. These args match what will be [the defaults](https://github.com/apache/cassandra-java-driver/pull/2096/changes#r3827716324) once that PR is merged so this entire profile can just be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-115: Java 25 support [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #2085:
URL: https://github.com/apache/cassandra-java-driver/pull/2085#discussion_r3937584774
##########
pom.xml:
##########
@@ -1068,6 +1068,19 @@ limitations under the License.]]></inlineHeader>
<mockitoopens.argline>--add-opens=java.base/jdk.internal.util.random=ALL-UNNAMED</mockitoopens.argline>
</properties>
</profile>
+ <profile>
+ <!-- workarounds for running tests with JDK21 -->
+ <id>test-jdk-25</id>
+ <activation>
+ <jdk>[25,)</jdk>
+ </activation>
+ <properties>
+ <!-- for DriverBlockHoundIntegrationIT when using JDK 13+, see https://github.com/reactor/BlockHound/issues/33 -->
+ <blockhound.argline>-XX:+AllowRedefinitionToAddDeleteMethods</blockhound.argline>
+ <!-- allow deep reflection for mockito when using JDK 17+, see https://stackoverflow.com/questions/70993863/mockito-can-not-mock-random-in-java-17 -->
+ <mockitoopens.argline>--add-opens=java.base/jdk.internal.util.random=ALL-UNNAMED</mockitoopens.argline>
+ </properties>
+ </profile>
Review Comment:
I did away with the "test-jdk-X" blocks as part of the work on CASSJAVA-135. The blocks for all support JDK versions (Java17 and Java21 in that example) were identical so there wasn't really any need to keep it in place. These args match what will be [the defaults](https://github.com/apache/cassandra-java-driver/pull/2096/changes#r3827716324) once that PR is merged so this entire profile can just be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org