[GitHub] [doris] morningman commented on a diff in pull request #13231: [feature-wip](CN Node)Support compute node

[GitBox <gi...@apache.org>]

morningman commented on code in PR #13231:
URL: https://github.com/apache/doris/pull/13231#discussion_r1002430817


##########
fe/fe-core/src/main/java/org/apache/doris/system/Backend.java:
##########
@@ -123,6 +123,9 @@ public enum BackendState {
     // creating this everytime we get it.
     @SerializedName(value = "locationTag", alternate = {"tag"})
     private Tag locationTag = Tag.DEFAULT_BACKEND_TAG;
+

Review Comment:
   We need to persist this field(annotated with `@SerializedName`), otherwise, other non-master FE will not known this tag.



##########
be/src/common/config.h:
##########
@@ -858,6 +858,16 @@ CONF_mInt64(nodechannel_pending_queue_max_bytes, "67108864");
 // so as to avoid occupying the execution thread for a long time.
 CONF_mInt32(max_fragment_start_wait_time_seconds, "30");
 
+// Temp config. True to use new file scan node to do load job. Will remove after fully test.

Review Comment:
   What is this for? I have just removed this 2 config?



##########
docs/zh-CN/docs/sql-manual/sql-reference/Show-Statements/SHOW-BACKENDS.md:
##########
@@ -52,6 +52,7 @@ SHOW BACKENDS
        10. UsedPct 表示磁盘已使用量百分比。
        11. ErrMsg 用于显示心跳失败时的错误信息。
        12. Status 用于以 JSON 格式显示BE的一些状态信息, 目前包括最后一次BE汇报其tablet的时间信息。
+       13. NodeRole用于展示节点角色, 现在有两种类型: Mix代表原来的节点类型, computation代表只做计算的节点类型.

Review Comment:
   I add a new column `HeartbeatFailureCounter` in #13568.
   But I forgot to modify the document here.
   Could you please add it for me? The content is:
   
   ```
   13. HeartbeatFailureCounter：现在当前连续失败的心跳次数，如果次数超过 `max_backend_heartbeat_failure_tolerance_count` 配置，则 isAlive 字段会置为 false。
   ```
   English:
   ```
   13. HeartbeatFailureCounter: The current number of heartbeats that have failed consecutively. If the number exceeds the `max_backend_heartbeat_failure_tolerance_count` configuration, the isAlive will be set to false.
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org