You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Rutherglen (Created) (JIRA)" <ji...@apache.org> on 2011/10/07 20:54:29 UTC
[jira] [Created] (LUCENE-3497) Make DirectoryReader protected
methods non-final
Make DirectoryReader protected methods non-final
------------------------------------------------
Key: LUCENE-3497
URL: https://issues.apache.org/jira/browse/LUCENE-3497
Project: Lucene - Java
Issue Type: Improvement
Components: core/index
Affects Versions: 3.4, 4.0
Reporter: Jason Rutherglen
Priority: Blocker
DirectoryReader has protected methods that are overridden and made final. This is silly because it prevents other classes from overriding DirectoryReader. The methods are doOpenIfChanged(*) and a handful of related variables that are private.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3497) Make DirectoryReader protected
methods non-final
Posted by "Jason Rutherglen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated LUCENE-3497:
-------------------------------------
Attachment: LUCENE-3497.patch
The patch makes most of what is private in DR protected. Protected is just like private, however, only subclasses can access protected methods and variables, or in the same package.
> Make DirectoryReader protected methods non-final
> ------------------------------------------------
>
> Key: LUCENE-3497
> URL: https://issues.apache.org/jira/browse/LUCENE-3497
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 3.4, 4.0
> Reporter: Jason Rutherglen
> Priority: Minor
> Attachments: LUCENE-3497.patch
>
>
> DirectoryReader has protected methods that are overridden and made final. This is silly because it prevents other classes from overriding DirectoryReader. The methods are doOpenIfChanged(*) and a handful of related variables that are private.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3497) Make DirectoryReader protected
methods non-final
Posted by "Jason Rutherglen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123102#comment-13123102 ]
Jason Rutherglen commented on LUCENE-3497:
------------------------------------------
I'll open another issue for the factory method of enabling Lucene to open custom DirectoryReader's.
> Make DirectoryReader protected methods non-final
> ------------------------------------------------
>
> Key: LUCENE-3497
> URL: https://issues.apache.org/jira/browse/LUCENE-3497
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 3.4, 4.0
> Reporter: Jason Rutherglen
> Priority: Minor
> Attachments: LUCENE-3497.patch
>
>
> DirectoryReader has protected methods that are overridden and made final. This is silly because it prevents other classes from overriding DirectoryReader. The methods are doOpenIfChanged(*) and a handful of related variables that are private.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3497) Make DirectoryReader protected
methods non-final
Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3497:
--------------------------------
Priority: Minor (was: Blocker)
DirectoryReader is a package private class: i don't see how this is a blocker issue for release.
> Make DirectoryReader protected methods non-final
> ------------------------------------------------
>
> Key: LUCENE-3497
> URL: https://issues.apache.org/jira/browse/LUCENE-3497
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 3.4, 4.0
> Reporter: Jason Rutherglen
> Priority: Minor
>
> DirectoryReader has protected methods that are overridden and made final. This is silly because it prevents other classes from overriding DirectoryReader. The methods are doOpenIfChanged(*) and a handful of related variables that are private.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org