[GitHub] [lucene-solr] dweiss commented on a change in pull request #1076: SOLR-14048: Improve Hadoop test sanity checks

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #1076: SOLR-14048: Improve Hadoop test sanity checks
URL: https://github.com/apache/lucene-solr/pull/1076#discussion_r357016993
 
 

 ##########
 File path: solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java
 ##########
 @@ -87,6 +99,23 @@ private static void checkHadoopWindows() {
         !Constants.WINDOWS || NativeIO.isAvailable());
   }
 
+  /**
+   * Ensure that the tests are picking up the modified Hadoop classes
+   */
+  private static void checkOverriddenHadoopClasses() {
+    List<Class<?>> modifiedHadoopClasses = Arrays.asList(BlockPoolSlice.class, DiskChecker.class,
 
 Review comment:
   Hi Kevin. Wouldn't it be easier to check the codebase (clazz.getProtectionDomain().getCodeSource()) of these classes and compare it to a known class that should reside in the same codebase? If these are equal then it's "our" code and it wouldn't need those extra fields (or reflection). 
   
   
   It may need an additional permission though.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org