Re: [PR] [#32064][prism] Keep elements heap in sequence order. [beam]

["damondouglas (via GitHub)" <gi...@apache.org>]

damondouglas commented on code in PR #32065:
URL: https://github.com/apache/beam/pull/32065#discussion_r1702305342


##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -688,6 +697,7 @@ func reElementResiduals(residuals []Residual, inputInfo PColInfo, rb RunBundle)
 					pane:      pn,
 					elmBytes:  elmBytes,
 					keyBytes:  keyBytes,
+					sequence:  len(unprocessedElements),

Review Comment:
   Non-blocking. I know that len has an `O(1)` but just curious why not just `for i, w := range ws { sequence: i }`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org