[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3883: Fixed double-build of TR RPMs in CiaB makefile

[GitBox <gi...@apache.org>]

ocket8888 opened a new pull request #3883: Fixed double-build of TR RPMs in CiaB makefile
URL: https://github.com/apache/trafficcontrol/pull/3883
 
 
   ## What does this PR (Pull Request) do?
   
   - [x] This PR is not related to any Issue
   
   When building packages for CDN-in-a-Box using `make` with multiple "jobs" (i.e. with `-j`), there is a race condition building the Traffic Router and Tomcat RPMs, since one build process creates both and they both depend on changes to the TR source. In cases where this manifested - which is often - the build will fail. This PR eliminates that by changing the rule to a pattern-based one, which `make` will now properly recognize as a single output (consisting of multiple files) of a single build process.
   
   
   ## Which Traffic Control components are affected by this PR?
   - CDN in a Box
   
   No docs because it's a bugfix
   
   ## What is the best way to verify this PR?
   Build the RPMs for CDN-in-a-Box using `make` with the `-j` flag, observe that it consistently has no issue creating RPMs for both Tomcat and Traffic Router (note that in order to do that, the `build_default` Docker network must already exist - which is accomplished by just having built an RPM on the same machine before - as otherwise duplicate networks will be created).
   
   No tests because this is just the build system for a toy environment.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   N/A - CDN-in-a-Box is not a supported component of Traffic Control, and no such support is purported to exist in any existing releases.
   
   ## The following criteria are ALL met by this PR
   - [x] I have explained why tests are unnecessary
   - [x] I have explained why documentation is unnecessary
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services