[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on a change in pull request #7: SLING-8447 - Add gauge for current retries per subscriber

[GitBox <gi...@apache.org>]

tmaret commented on a change in pull request #7: SLING-8447 - Add gauge for current retries per subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/7#discussion_r289371648
 
 

 ##########
 File path: src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java
 ##########
 @@ -278,6 +278,9 @@ public void activate(SubscriberConfiguration config, BundleContext context, Map<
                 format("Queue Processor for Subscriber agent %s", subAgentName));
 
         sender = messagingProvider.createSender();
+        
 
 Review comment:
   It was probably overlooked, the gauge must be deactivated in the deactivate method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services