You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/01/26 03:12:55 UTC
[GitHub] spark pull request #20401: [MINOR][SS][DOC] Fix Scala/Java doc examples for ...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20401
[MINOR][SS][DOC] Fix Scala/Java doc examples for `Trigger`
## What changes were proposed in this pull request?
This PR fixes Scala/Java doc examples in `Trigger.java`.
## How was this patch tested?
N/A.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-TRIGGER
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20401.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20401
----
commit 3de5e41eeca14fc123f44bff225c7b6475babe4e
Author: Dongjoon Hyun <do...@...>
Date: 2018-01-26T03:09:22Z
[MINOR][SS][DOC] Fix Scala/Java doc examples for `Trigger`
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Fix `Trigger` Scala/Java doc examples
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20401
**[Test build #86679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86679/testReport)** for PR 20401 at commit [`3de5e41`](https://github.com/apache/spark/commit/3de5e41eeca14fc123f44bff225c7b6475babe4e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20401: [MINOR][SS][DOC] Make `Trigger` Scala/Java doc ex...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20401#discussion_r164027523
--- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/Trigger.java ---
@@ -66,7 +66,7 @@ public static Trigger ProcessingTime(long interval, TimeUnit timeUnit) {
*
* {{{
* import scala.concurrent.duration._
- * df.writeStream.trigger(ProcessingTime(10.seconds))
+ * df.writeStream.trigger(Trigger.ProcessingTime(10.seconds))
--- End diff --
Also, `Trigger.ProcessingTime` supercedes `ProcessingTime`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20401: [MINOR][SS][DOC] Make `Trigger` Scala/Java doc ex...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20401#discussion_r164027455
--- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/Trigger.java ---
@@ -50,7 +50,7 @@ public static Trigger ProcessingTime(long intervalMs) {
*
* {{{
* import java.util.concurrent.TimeUnit
- * df.writeStream.trigger(ProcessingTime.create(10, TimeUnit.SECONDS))
+ * df.writeStream().trigger(Trigger.ProcessingTime(10, TimeUnit.SECONDS))
--- End diff --
Since this is a java-friendly example, we had better use `writeStream()`. And, `ProcessingTime.create` shows deprecation warning.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Fix `Trigger` Scala/Java doc examples
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20401
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Make `Trigger` Scala/Java doc examples ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20401
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/263/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Make `Trigger` Scala/Java doc examples ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20401
**[Test build #86679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86679/testReport)** for PR 20401 at commit [`3de5e41`](https://github.com/apache/spark/commit/3de5e41eeca14fc123f44bff225c7b6475babe4e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Fix `Trigger` Scala/Java doc examples
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20401
Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Fix `Trigger` Scala/Java doc examples
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20401
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86679/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Fix `Trigger` Scala/Java doc examples
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20401
Thank you for review, @jerryshao and @srowen .
Yep. This is all I found about `Trigger`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Make `Trigger` Scala/Java doc examples ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20401
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Fix `Trigger` Scala/Java doc examples
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20401
LGTM.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Fix `Trigger` Scala/Java doc examples
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20401
Thank you for merging this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20401: [MINOR][SS][DOC] Fix `Trigger` Scala/Java doc exa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20401
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20401: [MINOR][SS][DOC] Fix `Trigger` Scala/Java doc examples
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20401
Is that all you can find? @dongjoon-hyun
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org