[GitHub] [beam] alexeyinkin commented on a diff in pull request #24957: [ToB] [Frontend] Tour of Beam analytics

["alexeyinkin (via GitHub)" <gi...@apache.org>]

alexeyinkin commented on code in PR #24957:
URL: https://github.com/apache/beam/pull/24957#discussion_r1102764700


##########
playground/frontend/integration_test/miscellaneous_ui/enjoy_playground_test.dart:
##########
@@ -58,14 +56,18 @@ Future<void> _checkEnjoyingAndSendFeedback(WidgetTester wt) async {
   await wt.tap(find.feedbackDropdownSendButton());
   await wt.pumpAndSettle();
 
-  final context = wt.element(find.feedbackThumbUp());
-  final lastSentEvent = AnalyticsService.get(context).lastSentEvent;
+  final lastEvent = PlaygroundComponents.analyticsService.lastEvent;
   expect(
-    lastSentEvent,
-    AnalyticsEvent(
-      category: kFeedbackCategory,
-      action: kClickSendFeedbackEvent,
-      label: text,
+    lastEvent,
+    const FeedbackFormAnalyticsEvent(

Review Comment:
   This will change after #25034 
   I am keeping the merge simple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org