You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Ralph Goers <ra...@dslextreme.com> on 2015/08/26 22:49:53 UTC

Re:

I’ll try to take a look tonight.

Do you have feedback on the Assembler work?

Ralph

> On Aug 26, 2015, at 1:28 PM, Gary Gregory <ga...@gmail.com> wrote:
> 
> Hi All,
> 
> To make it easier to implement a LevelRangeFilter (patch with test here: https://issues.apache.org/jira/browse/LOG4J2-1106 <https://issues.apache.org/jira/browse/LOG4J2-1106>) I'd like to add a new method to the public API: org.apache.logging.log4j.Level.isInRange(Level, Level)
> 
> This seems like right place which since we already have:
> 
> - org.apache.logging.log4j.Level.isLessSpecificThan(Level)
> - org.apache.logging.log4j.Level.isMoreSpecificThan(Level)
> 
> Please see https://issues.apache.org/jira/browse/LOG4J2-1105 <https://issues.apache.org/jira/browse/LOG4J2-1105> for the patch (with tests).
> 
> New API: https://issues.apache.org/jira/browse/LOG4J2-1105 <https://issues.apache.org/jira/browse/LOG4J2-1105>
> New Filter: https://issues.apache.org/jira/browse/LOG4J2-1106 <https://issues.apache.org/jira/browse/LOG4J2-1106>
> 
> OK, not OK?
> 
> Gary
> 
> -- 
> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org  <ma...@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> 
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>

Re:

Posted by Xen <xe...@dds.nl>.
I'm sorry about not being there to review btw.

I've been a bit busy (or deplored) with installing Linux and all that and 
trying to configure it. It's a good waste of time and makes you think you 
should stop using computers ;-). How about spending at least 10 hours 
trying to get a certain type of port routing functioning? Won't work. How 
about using thin-provisioned LVM volumes when your kernel apparently turns 
out not to support it. Grub2 refuses to generate a new config, so you have 
to edit one by hand, which is better anyway. The mechanic for getting a 
chroot in OpenSUSE doesn't work in Kubuntu. Which causes you not to be 
able to generate a new initrd, which might be the problem. Then Windows 7 
fails installing updates or takes 3 hours to do so, for which I didn't 
have time. And now it won't boot at all, not even in safe mode.

So yeah I guess I've been busy ;-) :( :-/.

Regards, B.



On Thu, 27 Aug 2015, Gary Gregory wrote:

> FYI: I started reviewing but I have to take a break and get back in it
> later tonight.
>
> Gary
>
> On Wed, Aug 26, 2015 at 1:49 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> I’ll try to take a look tonight.
>>
>> Do you have feedback on the Assembler work?
>>
>> Ralph
>>
>> On Aug 26, 2015, at 1:28 PM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> Hi All,
>>
>> To make it easier to implement a LevelRangeFilter (patch with test here:
>> https://issues.apache.org/jira/browse/LOG4J2-1106) I'd like to add a new
>> method to the public API: org.apache.logging.log4j.Level.isInRange(Level,
>> Level)
>>
>> This seems like right place which since we already have:
>>
>> - org.apache.logging.log4j.Level.isLessSpecificThan(Level)
>> - org.apache.logging.log4j.Level.isMoreSpecificThan(Level)
>>
>> Please see https://issues.apache.org/jira/browse/LOG4J2-1105 for the
>> patch (with tests).
>>
>> New API: https://issues.apache.org/jira/browse/LOG4J2-1105
>> New Filter: https://issues.apache.org/jira/browse/LOG4J2-1106
>>
>> OK, not OK?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>

Re:

Posted by Gary Gregory <ga...@gmail.com>.
FYI: I started reviewing but I have to take a break and get back in it
later tonight.

Gary

On Wed, Aug 26, 2015 at 1:49 PM, Ralph Goers <ra...@dslextreme.com>
wrote:

> I’ll try to take a look tonight.
>
> Do you have feedback on the Assembler work?
>
> Ralph
>
> On Aug 26, 2015, at 1:28 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> Hi All,
>
> To make it easier to implement a LevelRangeFilter (patch with test here:
> https://issues.apache.org/jira/browse/LOG4J2-1106) I'd like to add a new
> method to the public API: org.apache.logging.log4j.Level.isInRange(Level,
> Level)
>
> This seems like right place which since we already have:
>
> - org.apache.logging.log4j.Level.isLessSpecificThan(Level)
> - org.apache.logging.log4j.Level.isMoreSpecificThan(Level)
>
> Please see https://issues.apache.org/jira/browse/LOG4J2-1105 for the
> patch (with tests).
>
> New API: https://issues.apache.org/jira/browse/LOG4J2-1105
> New Filter: https://issues.apache.org/jira/browse/LOG4J2-1106
>
> OK, not OK?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re:

Posted by Ralph Goers <ra...@dslextreme.com>.
I had already fixed that. I have added support for CustemLevels but not asynch loggers.  I should be able to upload a new patch tonight.

Ralph

> On Aug 26, 2015, at 2:07 PM, Gary Gregory <ga...@gmail.com> wrote:
> 
> On Wed, Aug 26, 2015 at 1:54 PM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
> On Wed, Aug 26, 2015 at 1:49 PM, Ralph Goers <ralph.goers@dslextreme.com <ma...@dslextreme.com>> wrote:
> I’ll try to take a look tonight.
> 
> Do you have feedback on the Assembler work?
> 
> Not yet, but I too, will look tonight!
> 
> I did apply the patch last night but there was a compile error as Remko noted. Do you plan on updating the patch again?
> 
> Gary
>  
> 
> Gary 
> 
> Ralph
> 
>> On Aug 26, 2015, at 1:28 PM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
>> 
>> Hi All,
>> 
>> To make it easier to implement a LevelRangeFilter (patch with test here: https://issues.apache.org/jira/browse/LOG4J2-1106 <https://issues.apache.org/jira/browse/LOG4J2-1106>) I'd like to add a new method to the public API: org.apache.logging.log4j.Level.isInRange(Level, Level)
>> 
>> This seems like right place which since we already have:
>> 
>> - org.apache.logging.log4j.Level.isLessSpecificThan(Level)
>> - org.apache.logging.log4j.Level.isMoreSpecificThan(Level)
>> 
>> Please see https://issues.apache.org/jira/browse/LOG4J2-1105 <https://issues.apache.org/jira/browse/LOG4J2-1105> for the patch (with tests).
>> 
>> New API: https://issues.apache.org/jira/browse/LOG4J2-1105 <https://issues.apache.org/jira/browse/LOG4J2-1105>
>> New Filter: https://issues.apache.org/jira/browse/LOG4J2-1106 <https://issues.apache.org/jira/browse/LOG4J2-1106>
>> 
>> OK, not OK?
>> 
>> Gary
>> 
>> -- 
>> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org  <ma...@apache.org>
>> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> 
>> Home: http://garygregory.com/ <http://garygregory.com/>
>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org  <ma...@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> 
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org  <ma...@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> 
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>

Re:

Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Aug 26, 2015 at 1:54 PM, Gary Gregory <ga...@gmail.com>
wrote:

> On Wed, Aug 26, 2015 at 1:49 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> I’ll try to take a look tonight.
>>
>> Do you have feedback on the Assembler work?
>>
>
> Not yet, but I too, will look tonight!
>

I did apply the patch last night but there was a compile error as Remko
noted. Do you plan on updating the patch again?

Gary


>
> Gary
>
>>
>> Ralph
>>
>> On Aug 26, 2015, at 1:28 PM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> Hi All,
>>
>> To make it easier to implement a LevelRangeFilter (patch with test here:
>> https://issues.apache.org/jira/browse/LOG4J2-1106) I'd like to add a new
>> method to the public API: org.apache.logging.log4j.Level.isInRange(Level,
>> Level)
>>
>> This seems like right place which since we already have:
>>
>> - org.apache.logging.log4j.Level.isLessSpecificThan(Level)
>> - org.apache.logging.log4j.Level.isMoreSpecificThan(Level)
>>
>> Please see https://issues.apache.org/jira/browse/LOG4J2-1105 for the
>> patch (with tests).
>>
>> New API: https://issues.apache.org/jira/browse/LOG4J2-1105
>> New Filter: https://issues.apache.org/jira/browse/LOG4J2-1106
>>
>> OK, not OK?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re:

Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Aug 26, 2015 at 1:49 PM, Ralph Goers <ra...@dslextreme.com>
wrote:

> I’ll try to take a look tonight.
>
> Do you have feedback on the Assembler work?
>

Not yet, but I too, will look tonight!

Gary

>
> Ralph
>
> On Aug 26, 2015, at 1:28 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> Hi All,
>
> To make it easier to implement a LevelRangeFilter (patch with test here:
> https://issues.apache.org/jira/browse/LOG4J2-1106) I'd like to add a new
> method to the public API: org.apache.logging.log4j.Level.isInRange(Level,
> Level)
>
> This seems like right place which since we already have:
>
> - org.apache.logging.log4j.Level.isLessSpecificThan(Level)
> - org.apache.logging.log4j.Level.isMoreSpecificThan(Level)
>
> Please see https://issues.apache.org/jira/browse/LOG4J2-1105 for the
> patch (with tests).
>
> New API: https://issues.apache.org/jira/browse/LOG4J2-1105
> New Filter: https://issues.apache.org/jira/browse/LOG4J2-1106
>
> OK, not OK?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory