You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailoale-db (via GitHub)" <gi...@apache.org> on 2024/08/14 15:58:39 UTC
[PR] [SPARK-49235] Refactor ResolveInlineTables rule so it doesn't traverse the whole tree [spark]
mihailoale-db opened a new pull request, #47760:
URL: https://github.com/apache/spark/pull/47760
### What changes were proposed in this pull request?
Refactoring `EvalInlineTables` in a way so we can use its body to resolve inline tables using `ResolveInlineTables` rule without traversing the whole tree.
### Why are the changes needed?
In the description of `EvalInlineTables` you can see that it is an optimizer rule which should run at the very end of the analysis phase. Nevertheless it is invoked while resolving inline tables in the analysis phase. We discovered that it can be done without traversing the whole tree so we refactored `EvalInlineTables` in a way that we can use it's body in `ResolveInlineTables` which improves readability of the code and its performance a bit.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing unit tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49235][SQL] Refactor ResolveInlineTables rule so it doesn't traverse the whole tree [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #47760:
URL: https://github.com/apache/spark/pull/47760#issuecomment-2289746132
Can we merge it @MaxGekk @cloud-fan ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49235][SQL] Refactor ResolveInlineTables rule so it doesn't traverse the whole tree [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #47760: [SPARK-49235][SQL] Refactor ResolveInlineTables rule so it doesn't traverse the whole tree
URL: https://github.com/apache/spark/pull/47760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49235][SQL] Refactor ResolveInlineTables rule so it doesn't traverse the whole tree [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #47760:
URL: https://github.com/apache/spark/pull/47760#issuecomment-2289773700
+1, LGTM. Merging to master.
Thank you, @mihailoale-db and @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49235][SQL] Refactor ResolveInlineTables rule so it doesn't traverse the whole tree [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #47760:
URL: https://github.com/apache/spark/pull/47760#issuecomment-2289778445
@mihailoale-db Congratulations with your first contribution to Apache Spark!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org