You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/01/03 06:17:08 UTC

[GitHub] [servicecomb-service-center] humingcheng opened a new pull request #615: Add comment for cache, add interface CacheReader, to make it easy to understand

humingcheng opened a new pull request #615: Add comment for cache, add interface CacheReader, to make it easy to understand
URL: https://github.com/apache/servicecomb-service-center/pull/615

Follow this checklist to help us incorporate your contribution quickly and easily:

- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

---

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue #615: Add comment for cache, add interface CacheReader, to make it easy to understand

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #615: Add comment for cache, add interface CacheReader, to make it easy to understand
URL: https://github.com/apache/servicecomb-service-center/pull/615#issuecomment-570485210
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=h1) Report
   > Merging [#615](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/9fa82ac8c847ea6f62161865ad1fccf443d73b3f?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #615      +/-   ##
   ==========================================
   + Coverage   57.57%   57.58%   +<.01%     
   ==========================================
     Files         205      205              
     Lines       15776    15776              
   ==========================================
   + Hits         9083     9084       +1     
     Misses       6046     6046              
   + Partials      647      646       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [server/plugin/pkg/discovery/cache\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX2t2Lmdv) | `95.78% <ø> (ø)` | :arrow_up: |
   | [server/plugin/pkg/discovery/etcd/indexer\_etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9ldGNkLmdv) | `100% <ø> (ø)` | :arrow_up: |
   | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <ø> (ø)` | :arrow_up: |
   | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <ø> (ø)` | :arrow_up: |
   | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <ø> (ø)` | :arrow_up: |
   | [server/plugin/pkg/discovery/etcd/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvYWRhcHRvci5nbw==) | `75% <ø> (ø)` | :arrow_up: |
   | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `66.42% <0%> (ø)` | :arrow_up: |
   | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: |
   | [server/core/backend/defer\_instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9kZWZlcl9pbnN0YW5jZS5nbw==) | `86.02% <100%> (ø)` | :arrow_up: |
   | [server/plugin/pkg/discovery/cache\_null.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX251bGwuZ28=) | `100% <100%> (ø)` | :arrow_up: |
   | ... and [8 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=footer). Last update [9fa82ac...9a3c544](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #615: Add comment for cache, add interface CacheReader, to make it easy to understand

Posted by GitBox <gi...@apache.org>.

tianxiaoliang merged pull request #615: Add comment for cache, add interface CacheReader, to make it easy to understand
URL: https://github.com/apache/servicecomb-service-center/pull/615
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls commented on issue #615: Add comment for cache, add interface CacheReader, to make it easy to understand

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #615: Add comment for cache, add interface CacheReader, to make it easy to understand
URL: https://github.com/apache/servicecomb-service-center/pull/615#issuecomment-570485119
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27894268/badge)](https://coveralls.io/builds/27894268)
   
   Coverage decreased (-0.07%) to 59.964% when pulling **af771c43c078d2d8d12ebaf2177ca325acdd6ec1 on humingcheng:master** into **9fa82ac8c847ea6f62161865ad1fccf443d73b3f on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] codecov-io commented on issue #615: Add comment for cache, add interface CacheReader, to make it easy to understand

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #615: Add comment for cache, add interface CacheReader, to make it easy to understand
URL: https://github.com/apache/servicecomb-service-center/pull/615#issuecomment-570485210
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=h1) Report
   > Merging [#615](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/9fa82ac8c847ea6f62161865ad1fccf443d73b3f?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #615      +/-   ##
   ==========================================
   - Coverage   57.57%   57.56%   -0.02%     
   ==========================================
     Files         205      205              
     Lines       15776    15776              
   ==========================================
   - Hits         9083     9081       -2     
   + Misses       6046     6045       -1     
   - Partials      647      650       +3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `66.42% <0%> (ø)` | :arrow_up: |
   | [server/plugin/pkg/discovery/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2luZGV4ZXJfY2FjaGUuZ28=) | `100% <100%> (ø)` | :arrow_up: |
   | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: |
   | [server/core/backend/defer\_instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9kZWZlcl9pbnN0YW5jZS5nbw==) | `86.02% <100%> (ø)` | :arrow_up: |
   | [server/plugin/pkg/discovery/cache\_null.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX251bGwuZ28=) | `100% <100%> (ø)` | :arrow_up: |
   | [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `56.75% <0%> (-2.71%)` | :arrow_down: |
   | [syncer/servicecenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc3luYy5nbw==) | `71.42% <0%> (-2.39%)` | :arrow_down: |
   | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `63.1% <0%> (-0.98%)` | :arrow_down: |
   | [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `80.57% <0%> (-0.58%)` | :arrow_down: |
   | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: |
   | ... and [3 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/615/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=footer). Last update [9fa82ac...af771c4](https://codecov.io/gh/apache/servicecomb-service-center/pull/615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls edited a comment on issue #615: Add comment for cache, add interface CacheReader, to make it easy to understand

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #615: Add comment for cache, add interface CacheReader, to make it easy to understand
URL: https://github.com/apache/servicecomb-service-center/pull/615#issuecomment-570485119
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27896022/badge)](https://coveralls.io/builds/27896022)
   
   Coverage decreased (-0.09%) to 59.95% when pulling **9a3c544290fd5b36bb52da5331ee547ecde24d8a on humingcheng:master** into **9fa82ac8c847ea6f62161865ad1fccf443d73b3f on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services