You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/19 16:28:29 UTC

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #2878: Author Gregory Nutt: update licenses to Apache

jerpelea opened a new pull request #2878:
URL: https://github.com/apache/incubator-nuttx/pull/2878


   ## Summary
   Gregory Nutt has submitted the SGA and we can migrate the licenses to Apache
   
   ## Impact
   None
   
   ## Testing
   None
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #2878: Author Gregory Nutt: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #2878:
URL: https://github.com/apache/incubator-nuttx/pull/2878#discussion_r579343879



##########
File path: net/bluetooth/bluetooth_callback.c
##########
@@ -2,33 +2,20 @@
  * net/bluetooth/bluetooth_callback.c
  * Forward events to waiting PF_BLUETOOTH sockets.

Review comment:
       This comment should be moved out of the license header.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #2878: Author Gregory Nutt: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #2878:
URL: https://github.com/apache/incubator-nuttx/pull/2878#discussion_r579350443



##########
File path: net/bluetooth/bluetooth_callback.c
##########
@@ -2,33 +2,20 @@
  * net/bluetooth/bluetooth_callback.c
  * Forward events to waiting PF_BLUETOOTH sockets.

Review comment:
       was fixed in the right way and the comment is moved after the license




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #2878: Author Gregory Nutt: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #2878:
URL: https://github.com/apache/incubator-nuttx/pull/2878#discussion_r579343879



##########
File path: net/bluetooth/bluetooth_callback.c
##########
@@ -2,33 +2,20 @@
  * net/bluetooth/bluetooth_callback.c
  * Forward events to waiting PF_BLUETOOTH sockets.

Review comment:
       ~~This comment should be moved out of the license header.~~
   I assumed the license header as the whole comment block.
   But if we assume that the Apache License header begins at line 5, then I think it is not an issue, right?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2878: Author Gregory Nutt: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2878:
URL: https://github.com/apache/incubator-nuttx/pull/2878


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org