[GitHub] LucaCanali commented on a change in pull request #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics

[GitBox <gi...@apache.org>]

LucaCanali commented on a change in pull request #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics
URL: https://github.com/apache/spark/pull/22279#discussion_r240932481
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
 ##########
 @@ -103,6 +103,14 @@ private[spark] class MetricsSystem private (
     sinks.foreach(_.start)
   }
 
+  // Same as start but this method only registers sinks
 
 Review comment:
   I have implemented the extra flag to start and tested the patch on a YARN cluster using a graphite sink for the metrics.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org