[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #8678: Core: Include summary without 'operation' when comparing view versions

["ajantha-bhat (via GitHub)" <gi...@apache.org>]

ajantha-bhat commented on code in PR #8678:
URL: https://github.com/apache/iceberg/pull/8678#discussion_r1341427213


##########
core/src/test/java/org/apache/iceberg/view/TestViewMetadata.java:
##########
@@ -578,6 +578,46 @@ public void viewVersionDeduplication() {
             ImmutableViewVersion.builder().from(viewVersionThree).versionId(3).build());
   }
 
+  @Test
+  public void viewVersionDeduplicationWithCustomSummary() {
+    // all view versions have the same ID
+    // additionally, there are duplicate view versions that only differ in the summary
+    ViewVersion viewVersionOne = newViewVersion(1, "select * from ns.tbl");
+    ViewVersion viewVersionTwo = newViewVersion(1, "select count(*) from ns.tbl");
+    ViewVersion viewVersionOneUpdated =
+        ImmutableViewVersion.builder()
+            .from(viewVersionTwo)

Review Comment:
   should be this? 
   
   ```suggestion
               .from(viewVersionOne)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org