[GitHub] [hive] pvargacl commented on a change in pull request #1196: HIVE-23791: Optimize ACID stats generation

[GitBox <gi...@apache.org>]

pvargacl commented on a change in pull request #1196:
URL: https://github.com/apache/hive/pull/1196#discussion_r448474859



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -1305,7 +1322,9 @@ public static Directory getAcidState(FileSystem fileSystem, Path candidateDirect
             bestBase, ignoreEmptyFiles, abortedDirectories, fs, validTxnList);
       }
     } else {
-      dirSnapshots = getHdfsDirSnapshots(fs, candidateDirectory);
+      if (dirSnapshots == null) {

Review comment:
       There is a slight problem here, if we are on hdfs and the file listing with id is supported. Few lines below there is a check for dirsnapshot == null, that was running every time for this case, but now it won't run if you call getacidstate with nonnull dirsnapshot




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org