You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "prantogg (via GitHub)" <gi...@apache.org> on 2023/11/16 18:54:51 UTC
[PR] [SEDONA-427] Add RS_RasterToWorldCoord [sedona]
prantogg opened a new pull request, #1123:
URL: https://github.com/apache/sedona/pull/1123
## Did you read the Contributor Guide?
- Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
## Is this PR related to a JIRA ticket?
- Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-427. The PR name follows the format `[SEDONA-XXX] my subject`.
## What changes were proposed in this PR?
- Add RS_RasterToWorldCoord
## How was this patch tested?
- Passed all new tests
## Did this PR include necessary documentation updates?
- Yes, I am adding a new API. I am using the [current SNAPSHOT version number](https://github.com/apache/sedona/blob/e2d3c02081d07f558fb40ba7e02ac6b2680b9d45/pom.xml#L29) in since `vX.Y.Z` format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-427] Add RS_RasterToWorldCoord [sedona]
Posted by "prantogg (via GitHub)" <gi...@apache.org>.
prantogg commented on code in PR #1123:
URL: https://github.com/apache/sedona/pull/1123#discussion_r1396340547
##########
common/src/main/java/org/apache/sedona/common/raster/RasterAccessors.java:
##########
@@ -106,6 +106,12 @@ public static double getWorldCoordY(GridCoverage2D raster, int colX, int rowY) t
return RasterUtils.getWorldCornerCoordinates(raster, colX, rowY).getY();
}
+ public static double[] getWorldCoord(GridCoverage2D raster, int colX, int rowY) throws TransformException {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-427] Add RS_RasterToWorldCoord [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1123:
URL: https://github.com/apache/sedona/pull/1123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-427] Add RS_RasterToWorldCoord [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1123:
URL: https://github.com/apache/sedona/pull/1123#discussion_r1396211227
##########
common/src/main/java/org/apache/sedona/common/raster/RasterAccessors.java:
##########
@@ -106,6 +106,12 @@ public static double getWorldCoordY(GridCoverage2D raster, int colX, int rowY) t
return RasterUtils.getWorldCornerCoordinates(raster, colX, rowY).getY();
}
+ public static double[] getWorldCoord(GridCoverage2D raster, int colX, int rowY) throws TransformException {
Review Comment:
The output should be a Geometry Point, not a double array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org