You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by peter liu <pe...@symantec.com> on 2014/09/27 23:01:56 UTC
Review Request 26117: HIVE-8094 add LIKE keyword support for SHOW
FUNCTIONS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26117/
-----------------------------------------------------------
Review request for hive and Thejas Nair.
Bugs: HIVE-8094
https://issues.apache.org/jira/browse/HIVE-8094
Repository: hive-git
Description
-------
It would be nice to add LIKE keyword support for SHOW FUNCTIONS as below, and keep the patterns consistent to the way as SHOW DATABASES, SHOW TABLES.
bq. SHOW FUNCTIONS LIKE 'foo*';
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b5e3ff0
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java f17b93d
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java eb20be3
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 37832be
ql/src/java/org/apache/hadoop/hive/ql/plan/ShowFunctionsDesc.java 5ea99f8
ql/src/test/queries/clientpositive/show_functions.q c09f50a
ql/src/test/results/clientpositive/show_functions.q.out 775cc74
Diff: https://reviews.apache.org/r/26117/diff/
Testing
-------
Thanks,
peter liu
Re: Review Request 26117: HIVE-8094 add LIKE keyword support for SHOW
FUNCTIONS
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26117/#review55177
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/plan/ShowFunctionsDesc.java
<https://reviews.apache.org/r/26117/#comment95565>
I think it is bit cleaner to have this and other constructors call the new constructor.
In this case it is not as important as the constructor is doing very little, but it is good to follow that patter to avoid code repetition.
ql/src/test/queries/clientpositive/show_functions.q
<https://reviews.apache.org/r/26117/#comment95566>
can you also add a test that involves both | and * ?
- Thejas Nair
On Sept. 27, 2014, 9:01 p.m., peter liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26117/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2014, 9:01 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-8094
> https://issues.apache.org/jira/browse/HIVE-8094
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> It would be nice to add LIKE keyword support for SHOW FUNCTIONS as below, and keep the patterns consistent to the way as SHOW DATABASES, SHOW TABLES.
>
> bq. SHOW FUNCTIONS LIKE 'foo*';
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b5e3ff0
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java f17b93d
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java eb20be3
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 37832be
> ql/src/java/org/apache/hadoop/hive/ql/plan/ShowFunctionsDesc.java 5ea99f8
> ql/src/test/queries/clientpositive/show_functions.q c09f50a
> ql/src/test/results/clientpositive/show_functions.q.out 775cc74
>
> Diff: https://reviews.apache.org/r/26117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> peter liu
>
>
Re: Review Request 26117: HIVE-8094 add LIKE keyword support for SHOW
FUNCTIONS
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26117/#review56105
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Oct. 10, 2014, 4:42 a.m., peter liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26117/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2014, 4:42 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-8094
> https://issues.apache.org/jira/browse/HIVE-8094
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> It would be nice to add LIKE keyword support for SHOW FUNCTIONS as below, and keep the patterns consistent to the way as SHOW DATABASES, SHOW TABLES.
>
> bq. SHOW FUNCTIONS LIKE 'foo*';
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d5374bc
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java d047b25
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 4e58ad8
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ef6d6f7
> ql/src/java/org/apache/hadoop/hive/ql/plan/ShowFunctionsDesc.java 5ea99f8
> ql/src/test/queries/clientpositive/show_functions.q c09f50a
> ql/src/test/results/clientpositive/show_functions.q.out 775cc74
>
> Diff: https://reviews.apache.org/r/26117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> peter liu
>
>
Re: Review Request 26117: HIVE-8094 add LIKE keyword support for SHOW
FUNCTIONS
Posted by peter liu <pe...@symantec.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26117/
-----------------------------------------------------------
(Updated Oct. 10, 2014, 4:42 a.m.)
Review request for hive and Thejas Nair.
Bugs: HIVE-8094
https://issues.apache.org/jira/browse/HIVE-8094
Repository: hive-git
Description
-------
It would be nice to add LIKE keyword support for SHOW FUNCTIONS as below, and keep the patterns consistent to the way as SHOW DATABASES, SHOW TABLES.
bq. SHOW FUNCTIONS LIKE 'foo*';
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d5374bc
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java d047b25
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 4e58ad8
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ef6d6f7
ql/src/java/org/apache/hadoop/hive/ql/plan/ShowFunctionsDesc.java 5ea99f8
ql/src/test/queries/clientpositive/show_functions.q c09f50a
ql/src/test/results/clientpositive/show_functions.q.out 775cc74
Diff: https://reviews.apache.org/r/26117/diff/
Testing
-------
Thanks,
peter liu
Re: Review Request 26117: HIVE-8094 add LIKE keyword support for SHOW
FUNCTIONS
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26117/#review55178
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/26117/#comment95567>
lets warn uses that this syntax is deprected and encourage them to use new syntax.
- Thejas Nair
On Sept. 27, 2014, 9:01 p.m., peter liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26117/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2014, 9:01 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-8094
> https://issues.apache.org/jira/browse/HIVE-8094
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> It would be nice to add LIKE keyword support for SHOW FUNCTIONS as below, and keep the patterns consistent to the way as SHOW DATABASES, SHOW TABLES.
>
> bq. SHOW FUNCTIONS LIKE 'foo*';
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b5e3ff0
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java f17b93d
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java eb20be3
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 37832be
> ql/src/java/org/apache/hadoop/hive/ql/plan/ShowFunctionsDesc.java 5ea99f8
> ql/src/test/queries/clientpositive/show_functions.q c09f50a
> ql/src/test/results/clientpositive/show_functions.q.out 775cc74
>
> Diff: https://reviews.apache.org/r/26117/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> peter liu
>
>