You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/08 04:24:20 UTC
[GitHub] [pulsar] MarvinCai opened a new pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
MarvinCai opened a new pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524#discussion_r571910326
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -315,6 +315,10 @@ Options
|`-m`, `--messages`|Comma-separated string of messages to send; either -m or -f must be specified|[]|
|`-n`, `--num-produce`|The number of times to send the message(s); the count of messages/files * num-produce should be below 1000|1|
|`-r`, `--rate`|Rate (in messages per second) at which to produce; a value 0 means to produce messages as fast as possible|0.0|
+|`-c`, `--chunking`|Should split the message and publish in chunks if message size is larger than allowed max size|false|
+|`-s`, `--separator`|Character to split messages string on default is comma|","|
+|`-k`, `--key`|Message key to add|key=value string, like k1=v1,k2=v2.|
+|`-p`, `--properties`|Properties to add, Comma separated| |
Review comment:
```suggestion
|`-p`, `--properties`|Properties to add, comma separated| |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on a change in pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on a change in pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524#discussion_r572453421
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -315,6 +315,10 @@ Options
|`-m`, `--messages`|Comma-separated string of messages to send; either -m or -f must be specified|[]|
|`-n`, `--num-produce`|The number of times to send the message(s); the count of messages/files * num-produce should be below 1000|1|
|`-r`, `--rate`|Rate (in messages per second) at which to produce; a value 0 means to produce messages as fast as possible|0.0|
+|`-c`, `--chunking`|Should split the message and publish in chunks if message size is larger than allowed max size|false|
+|`-s`, `--separator`|Character to split messages string on default is comma|","|
Review comment:
missing a comma I think, should be `Character to split messages string on, default is comma`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524#discussion_r571911137
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -335,7 +339,10 @@ Options
|`-s`, `--subscription-name`|Subscription name||
|`-t`, `--subscription-type`|The type of the subscription. Possible values: Exclusive, Shared, Failover, Key_Shared.|Exclusive|
|`-p`, `--subscription-position`|The position of the subscription. Possible values: Latest, Earliest.|Latest|
-
+|`-m`, `--subscription-mode`|Subscription mode.|Durable|
+|`-q`, `--queue-size`|Consumer receiver queue size.|0|
Review comment:
do you mean "The queue size of the consumer receiver"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524#issuecomment-775527166
> @MarvinCai thank you very much for adding the content. Does it apply only to 2.7.1 and 2.8.0?
We haven't update the doc for this client cli for a while I think, I'm not sure when did each options added to the client cli, so I only update 2.7.1 which is the version we're sure that all options are available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on a change in pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on a change in pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524#discussion_r572453421
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -315,6 +315,10 @@ Options
|`-m`, `--messages`|Comma-separated string of messages to send; either -m or -f must be specified|[]|
|`-n`, `--num-produce`|The number of times to send the message(s); the count of messages/files * num-produce should be below 1000|1|
|`-r`, `--rate`|Rate (in messages per second) at which to produce; a value 0 means to produce messages as fast as possible|0.0|
+|`-c`, `--chunking`|Should split the message and publish in chunks if message size is larger than allowed max size|false|
+|`-s`, `--separator`|Character to split messages string on default is comma|","|
Review comment:
missing a comma I think, should be `Character to split messages string on, default is comma`
but we're specifying default value for each option, removing the `default is comma` part
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524#discussion_r572062241
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -315,6 +315,10 @@ Options
|`-m`, `--messages`|Comma-separated string of messages to send; either -m or -f must be specified|[]|
|`-n`, `--num-produce`|The number of times to send the message(s); the count of messages/files * num-produce should be below 1000|1|
|`-r`, `--rate`|Rate (in messages per second) at which to produce; a value 0 means to produce messages as fast as possible|0.0|
+|`-c`, `--chunking`|Should split the message and publish in chunks if message size is larger than allowed max size|false|
+|`-s`, `--separator`|Character to split messages string on default is comma|","|
Review comment:
What does "Character to split messages string on default is comma" mean?
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -315,6 +315,10 @@ Options
|`-m`, `--messages`|Comma-separated string of messages to send; either -m or -f must be specified|[]|
|`-n`, `--num-produce`|The number of times to send the message(s); the count of messages/files * num-produce should be below 1000|1|
|`-r`, `--rate`|Rate (in messages per second) at which to produce; a value 0 means to produce messages as fast as possible|0.0|
+|`-c`, `--chunking`|Should split the message and publish in chunks if message size is larger than allowed max size|false|
+|`-s`, `--separator`|Character to split messages string on default is comma|","|
+|`-k`, `--key`|Message key to add|key=value string, like k1=v1,k2=v2.|
+|`-p`, `--properties`|Properties to add, Comma separated| |
Review comment:
Do you mean "Properties to add. If you want to add multiple properties, use the comma as the separator."?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524#discussion_r571910146
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -315,6 +315,10 @@ Options
|`-m`, `--messages`|Comma-separated string of messages to send; either -m or -f must be specified|[]|
|`-n`, `--num-produce`|The number of times to send the message(s); the count of messages/files * num-produce should be below 1000|1|
|`-r`, `--rate`|Rate (in messages per second) at which to produce; a value 0 means to produce messages as fast as possible|0.0|
+|`-c`, `--chunking`|Should split the message and publish in chunks if message size is larger than allowed max size|false|
Review comment:
```suggestion
|`-c`, `--chunking`|Split the message and publish in chunks if the message size is larger than the allowed max size|false|
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524#discussion_r571911336
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -335,7 +339,10 @@ Options
|`-s`, `--subscription-name`|Subscription name||
|`-t`, `--subscription-type`|The type of the subscription. Possible values: Exclusive, Shared, Failover, Key_Shared.|Exclusive|
|`-p`, `--subscription-position`|The position of the subscription. Possible values: Latest, Earliest.|Latest|
-
+|`-m`, `--subscription-mode`|Subscription mode.|Durable|
+|`-q`, `--queue-size`|Consumer receiver queue size.|0|
+|`-mc`, `--max_chunked_msg`|Max pending chunk messages.|0|
+|`-ac`, `--auto_ack_chunk_q_full`|Auto ack for oldest message on queue is full.|false|
Review comment:
```suggestion
|`-ac`, `--auto_ack_chunk_q_full`|Auto ack for the oldest message on queue is full.|false|
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on a change in pull request #9524: [Doc] Update pulsar-client cli doc with newer options.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on a change in pull request #9524:
URL: https://github.com/apache/pulsar/pull/9524#discussion_r572451483
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -335,7 +339,10 @@ Options
|`-s`, `--subscription-name`|Subscription name||
|`-t`, `--subscription-type`|The type of the subscription. Possible values: Exclusive, Shared, Failover, Key_Shared.|Exclusive|
|`-p`, `--subscription-position`|The position of the subscription. Possible values: Latest, Earliest.|Latest|
-
+|`-m`, `--subscription-mode`|Subscription mode.|Durable|
+|`-q`, `--queue-size`|Consumer receiver queue size.|0|
Review comment:
changed to `The size of consumer's receiver queue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org