[jira] Commented: (TAP5-937) LinkImpl does not handle parameters propery when passed into the constructor

["Joost Schouten (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783563#action_12783563 ] 

Joost Schouten commented on TAP5-937:
-------------------------------------

The problem only exists when using any UrlRewriteRule, activation context and additional parameters. The t:ac seems to be added to the URL before the UrlRewriting happens, where the AjaxFormLoop parameters seem to be added after the rewriting which results in the buildURI being called twice, causing the double questionmark.

> LinkImpl does not handle parameters propery when passed into the constructor
> ----------------------------------------------------------------------------
>
>                 Key: TAP5-937
>                 URL: https://issues.apache.org/jira/browse/TAP5-937
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1
>            Reporter: Joost Schouten
>         Attachments: parameter_addition_patch.txt
>
>
> I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s
> I'm building a failing test at this stage and will provide a patch once resolved.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.