You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/16 00:50:48 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32555: [SPARK-35408][PYTHON] Improve parameter validation in DataFrame.show

HyukjinKwon commented on a change in pull request #32555:
URL: https://github.com/apache/spark/pull/32555#discussion_r633023697



##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -482,10 +482,22 @@ def show(self, n=20, truncate=True, vertical=False):
          age  | 5
          name | Bob
         """
+
+        if not isinstance(n, int) or isinstance(n, bool):
+            raise TypeError(f'Parameter `n` (number of rows) must be an int')

Review comment:
       Can we just a plain string instead of f-string

##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -482,10 +482,22 @@ def show(self, n=20, truncate=True, vertical=False):
          age  | 5
          name | Bob
         """
+
+        if not isinstance(n, int) or isinstance(n, bool):
+            raise TypeError(f'Parameter `n` (number of rows) must be an int')
+
+        if not isinstance(vertical, bool):
+            raise TypeError(f'Parameter `vertical` must be a bool')

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org