You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Felix Knecht <fe...@apache.org> on 2008/02/13 08:47:07 UTC
Re: svn commit: r627296 - /directory/studio/branches/studio-maven/pom.xml
Something must have changed (probably in the surefire plugin), but using
released apache directory project 9 as parent I get test failures
whereas it passes using the older version 8.
That's why I haven't updated parent pom tag.
Regards
Felix
felixk@apache.org schrieb:
> Author: felixk
> Date: Tue Feb 12 23:43:39 2008
> New Revision: 627296
>
> URL: http://svn.apache.org/viewvc?rev=627296&view=rev
> Log:
> Use released versions of directory shared modules
>
> Modified:
> directory/studio/branches/studio-maven/pom.xml
>
> Modified: directory/studio/branches/studio-maven/pom.xml
> URL: http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/pom.xml?rev=627296&r1=627295&r2=627296&view=diff
> ==============================================================================
> --- directory/studio/branches/studio-maven/pom.xml (original)
> +++ directory/studio/branches/studio-maven/pom.xml Tue Feb 12 23:43:39 2008
> @@ -1641,17 +1641,17 @@
> <dependency>
> <groupId>org.apache.directory.shared</groupId>
> <artifactId>shared-ldap</artifactId>
> - <version>0.9.8-SNAPSHOT</version>
> + <version>0.9.8</version>
> </dependency>
> <dependency>
> <groupId>org.apache.directory.shared</groupId>
> <artifactId>shared-asn1</artifactId>
> - <version>0.9.8-SNAPSHOT</version>
> + <version>0.9.8</version>
> </dependency>
> <dependency>
> <groupId>org.apache.directory.shared</groupId>
> <artifactId>shared-converter</artifactId>
> - <version>0.9.8-SNAPSHOT</version>
> + <version>0.9.8</version>
> </dependency>
>
> <!-- Other dependencies -->
>
>
>
Re: svn commit: r627296 - /directory/studio/branches/studio-maven/pom.xml
Posted by Felix Knecht <fe...@apache.org>.
Hi Pierre Arnaud
With following patch it runs also fine with the '9' directory pom, but
I'm not sure if we can exclude abstract classes from test (would be
logical for me as the are abstract, be you never know).
WDYT?
Felix
Index: /home/felix/svn/apache/directory/studio/branches/studio-maven/pom.xml
===================================================================
---
/home/felix/svn/apache/directory/studio/branches/studio-maven/pom.xml
(revision 627296)
+++
/home/felix/svn/apache/directory/studio/branches/studio-maven/pom.xml
(working copy)
@@ -25,7 +25,7 @@
<parent>
<groupId>org.apache.directory.project</groupId>
<artifactId>project</artifactId>
- <version>8</version>
+ <version>9</version>
</parent>
<groupId>org.apache.directory.studio</groupId>
@@ -1876,6 +1876,14 @@
<target>1.5</target>
</configuration>
</plugin>
+ <plugin>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <excludes>
+ <exclude>**/Abstract*.java</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
</plugins>
<pluginManagement>
Re: svn commit: r627296 - /directory/studio/branches/studio-maven/pom.xml
Posted by Felix Knecht <fe...@apache.org>.
Pierre-Arnaud Marcelot schrieb:
> You're right, I just tested it too.
>
> I have the same issue on the apacheds trunk right now.
>
> The surefire plugin version has been modified in the project pom just
> before releasing the version 9.
>
> @@ -128,7 +143,7 @@
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire
> -plugin</artifactId>
> - <version>2.3</version>
> + <version>2.4.1</version>
> <configuration>
> <argLine>-Xmx1024m</argLine>
> </configuration>
>
>
> It is failing because it's not finding any test to run in the abstract
> test case classes (which is plain normal... :( ).
>
> Your patch works great, but you're right we never know. Maybe there
> are some important test cases starting with "Abstract"...
>
> We could maybe also add a blank test in each abstract test case...
> (Just to please the plugin).
We can also add exactly those (abstract) testcases which are not to be
executed instead of a general matching pattern like Abstract*.java. OTH
I wonder if it's good practice to have real test cases in an abstract class?
Just adding an empty test case to please a tool we use seems quite odd.
Felix
>
> Pierre-Arnaud
>
> On Feb 13, 2008 8:47 AM, Felix Knecht <felixk@apache.org
> <ma...@apache.org>> wrote:
>
> Something must have changed (probably in the surefire plugin), but
> using
> released apache directory project 9 as parent I get test failures
> whereas it passes using the older version 8.
>
> That's why I haven't updated parent pom tag.
>
> Regards
> Felix
>
>
>
> felixk@apache.org <ma...@apache.org> schrieb:
> > Author: felixk
> > Date: Tue Feb 12 23:43:39 2008
> > New Revision: 627296
> >
> > URL: http://svn.apache.org/viewvc?rev=627296&view=rev
> <http://svn.apache.org/viewvc?rev=627296&view=rev>
> > Log:
> > Use released versions of directory shared modules
> >
> > Modified:
> > directory/studio/branches/studio-maven/pom.xml
> >
> > Modified: directory/studio/branches/studio-maven/pom.xml
> > URL:
> http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/pom.xml?rev=627296&r1=627295&r2=627296&view=diff
> <http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/pom.xml?rev=627296&r1=627295&r2=627296&view=diff>
> >
> ==============================================================================
> > --- directory/studio/branches/studio-maven/pom.xml (original)
> > +++ directory/studio/branches/studio-maven/pom.xml Tue Feb 12
> 23:43:39 2008
> > @@ -1641,17 +1641,17 @@
> > <dependency>
> > <groupId>org.apache.directory.shared</groupId>
> > <artifactId>shared-ldap</artifactId>
> > - <version>0.9.8-SNAPSHOT</version>
> > + <version>0.9.8</version>
> > </dependency>
> > <dependency>
> > <groupId>org.apache.directory.shared</groupId>
> > <artifactId>shared-asn1</artifactId>
> > - <version>0.9.8-SNAPSHOT</version>
> > + <version>0.9.8</version>
> > </dependency>
> > <dependency>
> > <groupId>org.apache.directory.shared</groupId>
> > <artifactId>shared-converter</artifactId>
> > - <version>0.9.8-SNAPSHOT</version>
> > + <version>0.9.8</version>
> > </dependency>
> >
> > <!-- Other dependencies -->
> >
> >
> >
>
>
Re: svn commit: r627296 - /directory/studio/branches/studio-maven/pom.xml
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
You're right... Very odd...
Why did i omit the word 'abstract'???
Thanks for fixing this...
And moving to the 9 version of the parent pom.
Pierre-Arnaud
On Feb 13, 2008 9:45 AM, Felix Knecht <fe...@apache.org> wrote:
>
> >
> > It is failing because it's not finding any test to run in the abstract
> > test case classes (which is plain normal... :( ).
> >
> > Your patch works great, but you're right we never know. Maybe there
> > are some important test cases starting with "Abstract"...
> >
> > We could maybe also add a blank test in each abstract test case...
> > (Just to please the plugin).
>
> Silly question, but why is a class named Abstract* not abstract but
> public? Then it would work also!
>
> Index:
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractResponseTest.java
> ===================================================================
> ---
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractResponseTest.java
> (revision 627293)
> +++
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractResponseTest.java
> (working copy)
> @@ -33,7 +33,7 @@
> * @author <a href="mailto:dev@directory.apache.org">Apache Directory
> Project</a>
> * @version $Rev$, $Date$
> */
> -public class AbstractResponseTest extends TestCase
> +public abstract class AbstractResponseTest extends TestCase
> {
> /**
> * Asserts that parsing throws a correct XmlPullParserException due
> to an incorrect file
>
>
> Index:
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractTest.java
> ===================================================================
> ---
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractTest.java
> (revision 627293)
> +++
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractTest.java
> (working copy)
> @@ -33,7 +33,7 @@
> * @author <a href="mailto:dev@directory.apache.org">Apache Directory
> Project</a>
> * @version $Rev$, $Date$
> */
> -public class AbstractTest extends TestCase
> +abstract class AbstractTest extends TestCase
> {
> /**
> * Asserts that parsing throws a correct XmlPullParserException due
> to an incorrect file
>
>
>
>
> Felix
>
>
Re: svn commit: r627296 - /directory/studio/branches/studio-maven/pom.xml
Posted by Felix Knecht <fe...@apache.org>.
>
> It is failing because it's not finding any test to run in the abstract
> test case classes (which is plain normal... :( ).
>
> Your patch works great, but you're right we never know. Maybe there
> are some important test cases starting with "Abstract"...
>
> We could maybe also add a blank test in each abstract test case...
> (Just to please the plugin).
Silly question, but why is a class named Abstract* not abstract but
public? Then it would work also!
Index:
/home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractResponseTest.java
===================================================================
---
/home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractResponseTest.java
(revision 627293)
+++
/home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractResponseTest.java
(working copy)
@@ -33,7 +33,7 @@
* @author <a href="mailto:dev@directory.apache.org">Apache Directory
Project</a>
* @version $Rev$, $Date$
*/
-public class AbstractResponseTest extends TestCase
+public abstract class AbstractResponseTest extends TestCase
{
/**
* Asserts that parsing throws a correct XmlPullParserException due
to an incorrect file
Index:
/home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractTest.java
===================================================================
---
/home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractTest.java
(revision 627293)
+++
/home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractTest.java
(working copy)
@@ -33,7 +33,7 @@
* @author <a href="mailto:dev@directory.apache.org">Apache Directory
Project</a>
* @version $Rev$, $Date$
*/
-public class AbstractTest extends TestCase
+abstract class AbstractTest extends TestCase
{
/**
* Asserts that parsing throws a correct XmlPullParserException due
to an incorrect file
Felix
Re: svn commit: r627296 - /directory/studio/branches/studio-maven/pom.xml
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
You're right, I just tested it too.
I have the same issue on the apacheds trunk right now.
The surefire plugin version has been modified in the project pom just before
releasing the version 9.
> @@ -128,7 +143,7 @@
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> - <version>2.3</version>
> + <version>2.4.1</version>
> <configuration>
> <argLine>-Xmx1024m</argLine>
> </configuration>
>
It is failing because it's not finding any test to run in the abstract test
case classes (which is plain normal... :( ).
Your patch works great, but you're right we never know. Maybe there are some
important test cases starting with "Abstract"...
We could maybe also add a blank test in each abstract test case... (Just to
please the plugin).
Pierre-Arnaud
On Feb 13, 2008 8:47 AM, Felix Knecht <fe...@apache.org> wrote:
> Something must have changed (probably in the surefire plugin), but using
> released apache directory project 9 as parent I get test failures
> whereas it passes using the older version 8.
>
> That's why I haven't updated parent pom tag.
>
> Regards
> Felix
>
>
>
> felixk@apache.org schrieb:
> > Author: felixk
> > Date: Tue Feb 12 23:43:39 2008
> > New Revision: 627296
> >
> > URL: http://svn.apache.org/viewvc?rev=627296&view=rev
> > Log:
> > Use released versions of directory shared modules
> >
> > Modified:
> > directory/studio/branches/studio-maven/pom.xml
> >
> > Modified: directory/studio/branches/studio-maven/pom.xml
> > URL:
> http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/pom.xml?rev=627296&r1=627295&r2=627296&view=diff
> >
> ==============================================================================
> > --- directory/studio/branches/studio-maven/pom.xml (original)
> > +++ directory/studio/branches/studio-maven/pom.xml Tue Feb 12 23:43:39
> 2008
> > @@ -1641,17 +1641,17 @@
> > <dependency>
> > <groupId>org.apache.directory.shared</groupId>
> > <artifactId>shared-ldap</artifactId>
> > - <version>0.9.8-SNAPSHOT</version>
> > + <version>0.9.8</version>
> > </dependency>
> > <dependency>
> > <groupId>org.apache.directory.shared</groupId>
> > <artifactId>shared-asn1</artifactId>
> > - <version>0.9.8-SNAPSHOT</version>
> > + <version>0.9.8</version>
> > </dependency>
> > <dependency>
> > <groupId>org.apache.directory.shared</groupId>
> > <artifactId>shared-converter</artifactId>
> > - <version>0.9.8-SNAPSHOT</version>
> > + <version>0.9.8</version>
> > </dependency>
> >
> > <!-- Other dependencies -->
> >
> >
> >
>
>