You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/07/20 06:18:28 UTC
[GitHub] [incubator-iotdb] noneedname opened a new pull request #1523: python session client ver-0.10.0
noneedname opened a new pull request #1523:
URL: https://github.com/apache/incubator-iotdb/pull/1523
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1523: python session client ver-0.10.0
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1523:
URL: https://github.com/apache/incubator-iotdb/pull/1523
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1523: python session client ver-0.10.0
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #1523:
URL: https://github.com/apache/incubator-iotdb/pull/1523#discussion_r458040677
##########
File path: client-py/readme.md
##########
@@ -45,6 +45,7 @@ Optionally, if you know the basic usage of thrift, you can only download the thr
`service-rpc\src\main\thrift\rpc.thrift`, and simply use `thrift -gen py -out ./target/iotdb rpc.thrift`
to generate the python library.
-## Example
-We provided an example of how to use the thrift library to connect to IoTDB in `client-py/src
-/client_example.py`, please read it carefully before you write your own code.
\ No newline at end of file
+## Session Client & Example
+We packed up the Thrift interface in `client-py/src/session.py` (similar with its Java counterpart), also provided
+an example file `client-py/src/sessionExample.py` of how to use the session module. please read it carefully.
Review comment:
```suggestion
an example file `client-py/src/SessionExample.py` of how to use the session module. please read it carefully.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org