You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/12/07 11:55:27 UTC

[I] [Bug] META-INF issues in paimon-s3-impl-0.6.0-incubating.jar [incubator-paimon]

pjfanning opened a new issue, #2468:
URL: https://github.com/apache/incubator-paimon/issues/2468

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/incubator-paimon/issues) and found nothing similar.
   
   
   ### Paimon version
   
   0.6.0-rc2
   
   ### Compute Engine
   
   n/a
   
   ### Minimal reproduce step
   
   unzip https://repository.apache.org/content/repositories/orgapachepaimon-1031/org/apache/paimon/paimon-s3-impl/0.6.0-incubating/paimon-s3-impl-0.6.0-incubating.jar
   
   you'll find a nested META-INF dir
   
           0  09-12-2018 06:28   META-INF/versions/11/META-INF/
        2345  09-12-2018 06:28   META-INF/versions/11/META-INF/MANIFEST.MF
           0  09-12-2018 06:28   META-INF/versions/11/META-INF/versions/
           0  09-12-2018 06:28   META-INF/versions/11/META-INF/versions/9/
           0  09-12-2018 06:28   META-INF/versions/11/META-INF/versions/9/javax/
           0  09-12-2018 06:28   META-INF/versions/11/META-INF/versions/9/javax/xml/
           0  09-12-2018 06:28   META-INF/versions/11/META-INF/versions/9/javax/xml/bind/
        4403  09-12-2018 06:28   META-INF/versions/11/META-INF/versions/9/javax/xml/bind/ModuleUtil.class
       36551  09-12-2018 06:28   META-INF/versions/11/META-INF/LICENSE.txt
   
   
   ### What doesn't meet your expectations?
   
   We shouldn't include the nested META-INF dir
   
   ### Anything else?
   
   I think all of your bundle jars should be reviewed again. I have reported similar problems before.
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] META-INF issues in paimon-s3-impl-0.6.0-incubating.jar [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed issue #2468: [Bug] META-INF issues in paimon-s3-impl-0.6.0-incubating.jar
URL: https://github.com/apache/incubator-paimon/issues/2468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] META-INF issues in paimon-s3-impl-0.6.0-incubating.jar [incubator-paimon]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #2468:
URL: https://github.com/apache/incubator-paimon/issues/2468#issuecomment-1846826434

   META-INF/versions/11/META-INF/versions/9/javax/xml/bind/ModuleUtil.class should be META-INF/versions/9/javax/xml/bind/ModuleUtil.class
   
   these files should be excluded:
    META-INF/versions/11/META-INF/MANIFEST.MF
    META-INF/versions/11/META-INF/LICENSE.txt


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] META-INF issues in paimon-s3-impl-0.6.0-incubating.jar [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on issue #2468:
URL: https://github.com/apache/incubator-paimon/issues/2468#issuecomment-1847355329

   @pjfanning Thanks!
   
   We will try to exclude `MANIFEST.MF` and `LICENSE.txt` and test it.
   
   Now, only paimon-s3 and paimon-oss have the plugin mechanism, we will fix them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] META-INF issues in paimon-s3-impl-0.6.0-incubating.jar [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on issue #2468:
URL: https://github.com/apache/incubator-paimon/issues/2468#issuecomment-1846415526

   Hi @pjfanning , Very thanks to your review~
   
   Sorry for this, I thought the biggest problem was that the root directory didn't have all the META-INF content, so I followed this approach to fix it.
   
   Let me explain to you the current mechanism here. Currently, in order to isolate classes, we have extracted the jar into a subdirectory, which can avoid loading classes that are prone to conflicts in the default classloader. Then we use the new classloader during runtime to load the contents of the subdirectory.
   
   The entire jar has been decompressed to a subdirectory, and a new classloader will access the entire subdirectory. This requires that the contents of the subdirectory be complete files, including META-INF. Why? For example, classes for JDk11 will be included, which cannot be deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org