[jira] [Commented] (QPID-8740) [Broker-J] JUnit 6 migration - QpidUnitTestExtension should be stateless

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070242#comment-18070242 ] 

ASF GitHub Bot commented on QPID-8740:
--------------------------------------

vavrtom merged PR #384:
URL: https://github.com/apache/qpid-broker-j/pull/384




> [Broker-J] JUnit 6 migration - QpidUnitTestExtension should be stateless
> ------------------------------------------------------------------------
>
>                 Key: QPID-8740
>                 URL: https://issues.apache.org/jira/browse/QPID-8740
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>    Affects Versions: qpid-java-broker-10.0.1
>            Reporter: Daniil Kirilyuk
>            Priority: Minor
>             Fix For: qpid-java-broker-10.0.2
>
>
> QpidUnitTestExtension currently uses internal fields _testClass and _testMethod to store test metadata, which does not align with JUnit best practices. The logic of the extension should be changed to store no internal state. Documentation should be added.
> QpidUnitTestExtension should use getRequiredTestClass() / getRequiredTestMethod() to resolve class name and method name. Class variables _testClass and _testMethod storing this information will not be needed anymore.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org