You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Mike Tutkowski <mi...@solidfire.com> on 2014/07/08 22:50:04 UTC

Re: Review Request 23098: Updated Marvin code to support more properties.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23098/#review47465
-----------------------------------------------------------


It looks like the base.py file has been relocated for the 4.5 release.

Can you please regenerate your diff using the 4.5 branch?

Thanks!

- Mike Tutkowski


On June 26, 2014, 5:13 p.m., Vania Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23098/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 5:13 p.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Building automated integration tests that needed additional properties added to Marvin code. 
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/integration/lib/base.py 95b7fe9 
> 
> Diff: https://reviews.apache.org/r/23098/diff/
> 
> 
> Testing
> -------
> 
> Ran new code against my integration tests, and it was successful. 
> 
> 
> Thanks,
> 
> Vania Xu
> 
>


Re: Review Request 23098: Updated Marvin code to support more properties.

Posted by Vania Xu <va...@gmail.com>.

> On July 8, 2014, 8:50 p.m., Mike Tutkowski wrote:
> > It looks like the base.py file has been relocated for the 4.5 release.
> > 
> > Can you please regenerate your diff using the 4.5 branch?
> > 
> > Thanks!

I'll go ahead and upload a new diff. 


- Vania


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23098/#review47465
-----------------------------------------------------------


On June 26, 2014, 11:13 p.m., Vania Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23098/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 11:13 p.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Building automated integration tests that needed additional properties added to Marvin code. 
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/integration/lib/base.py 95b7fe9 
> 
> Diff: https://reviews.apache.org/r/23098/diff/
> 
> 
> Testing
> -------
> 
> Ran new code against my integration tests, and it was successful. 
> 
> 
> Thanks,
> 
> Vania Xu
> 
>