[GitHub] saandrews commented on a change in pull request #758: Add option to persist unack-msg range to cursor-ledger if range is high

[gi...@git.apache.org]

saandrews commented on a change in pull request #758: Add option to persist unack-msg range to cursor-ledger if range is high
URL: https://github.com/apache/incubator-pulsar/pull/758#discussion_r138767010
 
 

 ##########
 File path: conf/standalone.conf
 ##########
 @@ -246,6 +246,19 @@ managedLedgerCursorMaxEntriesPerLedger=50000
 # Max time before triggering a rollover on a cursor ledger
 managedLedgerCursorRolloverTimeInSeconds=14400
 
+# Max number of "acknowledgment holes" that are going to be persistently stored.
+# When acknowledging out of order, a consumer will leave holes that are supposed
+# to be quickly filled by acking all the messages. The information of which
+# messages are acknowledged is persisted by compressing in "ranges" of messages
+# that were acknowledged. After the max number of ranges is reached, the information
+# will only be tracked in memory and messages will be redelivered in case of
+# crashes.
+managedLedgerMaxUnackedRangesToPersist=1000
+
+# Max number of "acknowledgment holes" that can be stored in Zookeeper. If number of unack message range is higher
+# than this limit then broker will persist unacked ranges into bookkeeper to avoid additional data overhead into
+# zookeeper.  
+managedLedgerMaxUnackedRangesToPersistInZooKeeper=1000
 
 Review comment:
   I think having this initially would be useful for us to tune and realize the suitable size. Once we are comfortable with a value, we can remove the config.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services