You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Hyunsik Choi <hy...@apache.org> on 2014/03/04 12:09:51 UTC
Review Request 18731: TAJO-650: Repartitioner::scheduleHashShuffledFetches
should adjust the number of tasks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18731/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-650
https://issues.apache.org/jira/browse/TAJO-650
Repository: tajo
Description
-------
Even though Repartitioner::scheduleHashShuffledFetches gets the number of proper number of tasks for reoptimization, it does not adjust the number of tasks. It seems to be omitted in some change. This patch recovers the feature.
Diffs
-----
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 7d7ecadf30e2553cb62164e42e09287bffc4bee5
Diff: https://reviews.apache.org/r/18731/diff/
Testing
-------
Thanks,
Hyunsik Choi
Re: Review Request 18731: TAJO-650:
Repartitioner::scheduleHashShuffledFetches should adjust the number of tasks
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18731/#review36337
-----------------------------------------------------------
Ship it!
+1
Push it. :)
- Jung JaeHwa
On March 6, 2014, 4:55 a.m., Hyunsik Choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18731/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 4:55 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-650
> https://issues.apache.org/jira/browse/TAJO-650
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Even though Repartitioner::scheduleHashShuffledFetches gets the number of proper number of tasks for reoptimization, it does not adjust the number of tasks. It seems to be omitted in some change. This patch recovers the feature.
>
>
> Diffs
> -----
>
> tajo-common/src/main/java/org/apache/tajo/util/TUtil.java 310d187d7e931bd0cd88de14f76074fe2326582a
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 7d7ecadf30e2553cb62164e42e09287bffc4bee5
>
> Diff: https://reviews.apache.org/r/18731/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Hyunsik Choi
>
>
Re: Review Request 18731: TAJO-650:
Repartitioner::scheduleHashShuffledFetches should adjust the number of tasks
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18731/
-----------------------------------------------------------
(Updated March 6, 2014, 1:55 p.m.)
Review request for Tajo.
Changes
-------
Fixed the bug of the round robin schedule.
Bugs: TAJO-650
https://issues.apache.org/jira/browse/TAJO-650
Repository: tajo
Description
-------
Even though Repartitioner::scheduleHashShuffledFetches gets the number of proper number of tasks for reoptimization, it does not adjust the number of tasks. It seems to be omitted in some change. This patch recovers the feature.
Diffs (updated)
-----
tajo-common/src/main/java/org/apache/tajo/util/TUtil.java 310d187d7e931bd0cd88de14f76074fe2326582a
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 7d7ecadf30e2553cb62164e42e09287bffc4bee5
Diff: https://reviews.apache.org/r/18731/diff/
Testing
-------
mvn clean install
Thanks,
Hyunsik Choi
Re: Review Request 18731: TAJO-650:
Repartitioner::scheduleHashShuffledFetches should adjust the number of tasks
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18731/
-----------------------------------------------------------
(Updated March 4, 2014, 8:10 p.m.)
Review request for Tajo.
Bugs: TAJO-650
https://issues.apache.org/jira/browse/TAJO-650
Repository: tajo
Description
-------
Even though Repartitioner::scheduleHashShuffledFetches gets the number of proper number of tasks for reoptimization, it does not adjust the number of tasks. It seems to be omitted in some change. This patch recovers the feature.
Diffs
-----
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java 7d7ecadf30e2553cb62164e42e09287bffc4bee5
Diff: https://reviews.apache.org/r/18731/diff/
Testing (updated)
-------
mvn clean install
Thanks,
Hyunsik Choi