You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 09:25:28 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25053: Retrieve airflow branch/constraints from env variables
potiuk opened a new pull request, #25053:
URL: https://github.com/apache/airflow/pull/25053
We are using the "main" breeze to build even v2-3 images and
it has to retrieve the branch and constraints not from the
Python constants but from environment variables that are
set by build-image.yaml. Otherwise "main" is used to push/pull
image and constraints.
This pr changes the retrieval in build image to retrieve
branch, constraints branch (and debian version) from env
variables if they are set.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25053: Retrieve airflow branch/constraints from env variables
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25053:
URL: https://github.com/apache/airflow/pull/25053#issuecomment-1184215261
The branch env variables are set here: https://github.com/apache/airflow/blob/5e0160fe20ef1edc34d8f0a8e17a193504e4c541/.github/workflows/build-images.yml#L116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25053: Retrieve airflow branch/constraints from env variables
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25053:
URL: https://github.com/apache/airflow/pull/25053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25053: Retrieve airflow branch/constraints from env variables
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25053:
URL: https://github.com/apache/airflow/pull/25053#issuecomment-1187764865
Also woudl love some revirews here. I need that one to get the "PR to v2-3-stable" flow working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25053: Retrieve airflow branch/constraints from env variables
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25053:
URL: https://github.com/apache/airflow/pull/25053#issuecomment-1184212977
We need than one merged in main in order to #25050 to succed in v2-3-stable branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org