You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "suibianwanwank (via GitHub)" <gi...@apache.org> on 2024/08/12 09:27:52 UTC
[PR] [CALCITE-6501] Assertion Error in JoinUnifyRule Due to Type Mismatch [calcite]
suibianwanwank opened a new pull request, #3912:
URL: https://github.com/apache/calcite/pull/3912
Assertion errors occur in some joinUnifyRules because of the change in nullable type produced by the join. Intercepts these cases and replaces the assertion error with a return of null. For a specific example, see the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6501] Assertion Error in JoinUnifyRule Due to Type Mismatch [calcite]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #3912:
URL: https://github.com/apache/calcite/pull/3912#discussion_r1714529227
##########
core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java:
##########
@@ -1136,6 +1136,90 @@ protected final MaterializedViewFixture sql(String materialize,
sql(mv, query).ok();
}
+ @Test void testLeftProjectOnRightJoinToJoinFailed() {
Review Comment:
Add jira link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6501] Assertion Error in JoinUnifyRule Due to Type Mismatch [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3912:
URL: https://github.com/apache/calcite/pull/3912#issuecomment-2283518443
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3912) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3912&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3912&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3912&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [93.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3912&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3912&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3912)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6501] Assertion Error in JoinUnifyRule Due to Type Mismatch [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu merged PR #3912:
URL: https://github.com/apache/calcite/pull/3912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6501] Assertion Error in JoinUnifyRule Due to Type Mismatch [calcite]
Posted by "suibianwanwank (via GitHub)" <gi...@apache.org>.
suibianwanwank commented on code in PR #3912:
URL: https://github.com/apache/calcite/pull/3912#discussion_r1714589518
##########
core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java:
##########
@@ -1136,6 +1136,90 @@ protected final MaterializedViewFixture sql(String materialize,
sql(mv, query).ok();
}
+ @Test void testLeftProjectOnRightJoinToJoinFailed() {
Review Comment:
Done✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6501] Assertion Error in JoinUnifyRule Due to Type Mismatch [calcite]
Posted by "suibianwanwank (via GitHub)" <gi...@apache.org>.
suibianwanwank commented on PR #3912:
URL: https://github.com/apache/calcite/pull/3912#issuecomment-2292514054
I've squash the commits and if there are no more reviews, I think it's ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6501] Assertion Error in JoinUnifyRule Due to Type Mismatch [calcite]
Posted by "suibianwanwank (via GitHub)" <gi...@apache.org>.
suibianwanwank commented on PR #3912:
URL: https://github.com/apache/calcite/pull/3912#issuecomment-2292525495
Thanks for your review @mihaibudiu @caicancai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6501] Assertion Error in JoinUnifyRule Due to Type Mismatch [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3912:
URL: https://github.com/apache/calcite/pull/3912#issuecomment-2285359088
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3912) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3912&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3912&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3912&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [93.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3912&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3912&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3912)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org