You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/11/07 09:11:44 UTC

[GitHub] [echarts] Ovilia opened a new pull request, #17882: chore: start a local server for testing when run dev #17868

Ovilia opened a new pull request, #17882:
URL: https://github.com/apache/echarts/pull/17882

   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   Start a local server when run `npm run dev` and update the README. Hopefully, this can better help new contributors to get started.
   
   ### Fixed issues
   
   #17868
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: How does it behave after the fixing?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17882: chore: start a local server for testing when run dev #17868

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17882:
URL: https://github.com/apache/echarts/pull/17882#issuecomment-1305306704

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] AntiMoron commented on pull request #17882: chore: start a local server for testing when run dev #17868

Posted by GitBox <gi...@apache.org>.
AntiMoron commented on PR #17882:
URL: https://github.com/apache/echarts/pull/17882#issuecomment-1306833245

   Thanks @Ovilia 
   
   That's why echarts' better than other Chinese open source softwares.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia merged pull request #17882: chore: start a local server for testing when run dev #17868

Posted by GitBox <gi...@apache.org>.
Ovilia merged PR #17882:
URL: https://github.com/apache/echarts/pull/17882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia commented on pull request #17882: chore: start a local server for testing when run dev #17868

Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17882:
URL: https://github.com/apache/echarts/pull/17882#issuecomment-1305387164

   > The former command may block the latter command.
   
   It doesn't seem to be blocked to me. Can you give a more detailed explanation? In my environment, `Bundled with esbuild` is printed after the command and it prints again on file changes in `src`.
   
   `npx concurrently` gives extra prompt for developers to confirm so I think if it works without concurrently, it would be better:
   
   ```sh
   Need to install the following packages:
     concurrently@7.5.0
   Ok to proceed? (y)
   ```
   
   And there are other problems with your suggestion:
   
   ```sh
   [0] /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
   [0] /bin/sh: -c: line 1: syntax error: unexpected end of file
   [1] /bin/sh: run: command not found
   [0] "npm exited with code 2
   [2] /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
   [2] /bin/sh: -c: line 1: syntax error: unexpected end of file
   [1] run exited with code 127
   [2] dev:fast" exited with code 2
   [3] /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
   [3] /bin/sh: -c: line 1: syntax error: unexpected end of file
   [3] "npx exited with code 2
   ```
   
   I'm using Bash on Mac terminal.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17882: chore: start a local server for testing when run dev #17868

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17882:
URL: https://github.com/apache/echarts/pull/17882#issuecomment-1306599133

   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia commented on pull request #17882: chore: start a local server for testing when run dev #17868

Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17882:
URL: https://github.com/apache/echarts/pull/17882#issuecomment-1306568025

   It seems Windows and Mac shell have some differences. @plainheart 's suggestions works well in `scripts` in `package.json` so I used this command. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] plainheart commented on pull request #17882: chore: start a local server for testing when run dev #17868

Posted by GitBox <gi...@apache.org>.
plainheart commented on PR #17882:
URL: https://github.com/apache/echarts/pull/17882#issuecomment-1306587448

   > npx `concurrently` gives extra prompt for developers to confirm so I think if it works without concurrently, it would be better:
   
   Thanks for accepting the suggestion! Maybe we can pass `-y` to `npx` to avoid the installation tip.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org