You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/08/29 21:58:11 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1032: [SYSTEMDS-2558,2554,2561,2556,2557,2559] Federated transform apply + binning and omit

mboehm7 commented on pull request #1032:
URL: https://github.com/apache/systemds/pull/1032#issuecomment-683346259


   LGTM - thanks for this extension @kev-inn. Overall, this looks very good. I just made some formatting changes, fixed the merge conflicts, fixed a missing frame block release in `GetColumnNames` and `InitRowsToRemoveOmit`, and left a performance TODO in the `EncoderOmit`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org