You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "klesh (via GitHub)" <gi...@apache.org> on 2023/04/17 03:56:35 UTC
[GitHub] [incubator-devlake] klesh opened a new pull request, #4939: fix: bitbucket pr_commits/pr_commits have the incorrect FK to pr
klesh opened a new pull request, #4939:
URL: https://github.com/apache/incubator-devlake/pull/4939
### Summary
Fixes #4938
### Does this close any open issues?
Closes #4938
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #4939: fix: bitbucket pr_commits/pr_commits have the incorrect FK to pr
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 merged PR #4939:
URL: https://github.com/apache/incubator-devlake/pull/4939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mappjzc commented on a diff in pull request #4939: fix: bitbucket pr_commits/pr_commits have the incorrect FK to pr
Posted by "mappjzc (via GitHub)" <gi...@apache.org>.
mappjzc commented on code in PR #4939:
URL: https://github.com/apache/incubator-devlake/pull/4939#discussion_r1168330464
##########
backend/plugins/refdiff/tasks/deployment_commit_diff_calculator.go:
##########
@@ -114,6 +114,7 @@ func CalculateDeploymentCommitsDiff(taskCtx plugin.SubTaskContext) errors.Error
if err != nil {
return err
}
+ batch_save.Flush()
Review Comment:
why here flush again and not catch the error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #4939: fix: bitbucket pr_commits/pr_commits have the incorrect FK to pr
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #4939:
URL: https://github.com/apache/incubator-devlake/pull/4939#discussion_r1168499438
##########
backend/plugins/refdiff/tasks/deployment_commit_diff_calculator.go:
##########
@@ -114,6 +114,7 @@ func CalculateDeploymentCommitsDiff(taskCtx plugin.SubTaskContext) errors.Error
if err != nil {
return err
}
+ batch_save.Flush()
Review Comment:
good catch. rebase error. fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org