You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/03/20 16:14:00 UTC
Review Request 57781: Configuration Markdown Not Property Parsed By
Some Editors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57781/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Robert Levas.
Bugs: AMBARI-20502
https://issues.apache.org/jira/browse/AMBARI-20502
Repository: ambari
Description
-------
Some markdown displays, like GitHub, don't properly display the configuration markdown. Sections appear as:
{code}
####Alerts & Notifications | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | alerts.execution.scheduler.threadpool.size.core | 2 | 2 | 4 | 4 | | alerts.execution.scheduler.threadpool.size.max | 2 | 2 | 8 | 8 | | alerts.execution.scheduler.threadpool.worker.size | 400 | 2000 | 4000 | 20000 | | alerts.cache.enabled | false | false | false | true | | alerts.cache.flush.interval | 10 | 10 | 10 | 10 | | alerts.cache.size | 50000 | 50000 | 100000 | 100000 | ####Jetty API & Agent Thread Pools | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | client.threadpool.size.max | 25 | 35 | 50 | 65 | | agent.threadpool.size.max | 25 | 35 | 75 | 100 |
{code}
Diffs
-----
ambari-server/docs/configuration/index.md 7a7f3b9
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 20431f6
Diff: https://reviews.apache.org/r/57781/diff/1/
Testing
-------
Created a feature branch on Github to test this change. Verified that the Markdown has been corrected.
Thanks,
Jonathan Hurley
Re: Review Request 57781: Configuration Markdown Not Property Parsed
By Some Editors
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On March 20, 2017, 1:26 p.m., Alejandro Fernandez wrote:
> > Typo in review title, "Properly"
Thanks!
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57781/#review169467
-----------------------------------------------------------
On March 20, 2017, 12:13 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57781/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 12:13 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-20502
> https://issues.apache.org/jira/browse/AMBARI-20502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some markdown displays, like GitHub, don't properly display the configuration markdown. Sections appear as:
>
> {code}
> ####Alerts & Notifications | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | alerts.execution.scheduler.threadpool.size.core | 2 | 2 | 4 | 4 | | alerts.execution.scheduler.threadpool.size.max | 2 | 2 | 8 | 8 | | alerts.execution.scheduler.threadpool.worker.size | 400 | 2000 | 4000 | 20000 | | alerts.cache.enabled | false | false | false | true | | alerts.cache.flush.interval | 10 | 10 | 10 | 10 | | alerts.cache.size | 50000 | 50000 | 100000 | 100000 | ####Jetty API & Agent Thread Pools | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | client.threadpool.size.max | 25 | 35 | 50 | 65 | | agent.threadpool.size.max | 25 | 35 | 75 | 100 |
> {code}
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 7a7f3b9
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 20431f6
>
>
> Diff: https://reviews.apache.org/r/57781/diff/1/
>
>
> Testing
> -------
>
> Created a feature branch on Github to test this change. Verified that the Markdown has been corrected.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 57781: Configuration Markdown Not Property Parsed
By Some Editors
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57781/#review169467
-----------------------------------------------------------
Ship it!
Typo in review title, "Properly"
- Alejandro Fernandez
On March 20, 2017, 4:13 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57781/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 4:13 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-20502
> https://issues.apache.org/jira/browse/AMBARI-20502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some markdown displays, like GitHub, don't properly display the configuration markdown. Sections appear as:
>
> {code}
> ####Alerts & Notifications | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | alerts.execution.scheduler.threadpool.size.core | 2 | 2 | 4 | 4 | | alerts.execution.scheduler.threadpool.size.max | 2 | 2 | 8 | 8 | | alerts.execution.scheduler.threadpool.worker.size | 400 | 2000 | 4000 | 20000 | | alerts.cache.enabled | false | false | false | true | | alerts.cache.flush.interval | 10 | 10 | 10 | 10 | | alerts.cache.size | 50000 | 50000 | 100000 | 100000 | ####Jetty API & Agent Thread Pools | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | client.threadpool.size.max | 25 | 35 | 50 | 65 | | agent.threadpool.size.max | 25 | 35 | 75 | 100 |
> {code}
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 7a7f3b9
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 20431f6
>
>
> Diff: https://reviews.apache.org/r/57781/diff/1/
>
>
> Testing
> -------
>
> Created a feature branch on Github to test this change. Verified that the Markdown has been corrected.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 57781: Configuration Markdown Not Properly Parsed
By Some Editors
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57781/
-----------------------------------------------------------
(Updated March 20, 2017, 2:52 p.m.)
Review request for Ambari, Nate Cole and Robert Levas.
Summary (updated)
-----------------
Configuration Markdown Not Properly Parsed By Some Editors
Bugs: AMBARI-20502
https://issues.apache.org/jira/browse/AMBARI-20502
Repository: ambari
Description
-------
Some markdown displays, like GitHub, don't properly display the configuration markdown. Sections appear as:
{code}
####Alerts & Notifications | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | alerts.execution.scheduler.threadpool.size.core | 2 | 2 | 4 | 4 | | alerts.execution.scheduler.threadpool.size.max | 2 | 2 | 8 | 8 | | alerts.execution.scheduler.threadpool.worker.size | 400 | 2000 | 4000 | 20000 | | alerts.cache.enabled | false | false | false | true | | alerts.cache.flush.interval | 10 | 10 | 10 | 10 | | alerts.cache.size | 50000 | 50000 | 100000 | 100000 | ####Jetty API & Agent Thread Pools | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | client.threadpool.size.max | 25 | 35 | 50 | 65 | | agent.threadpool.size.max | 25 | 35 | 75 | 100 |
{code}
Diffs
-----
ambari-server/docs/configuration/index.md 7a7f3b9
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 20431f6
Diff: https://reviews.apache.org/r/57781/diff/1/
Testing
-------
Created a feature branch on Github to test this change. Verified that the Markdown has been corrected.
Thanks,
Jonathan Hurley
Re: Review Request 57781: Configuration Markdown Not Property Parsed
By Some Editors
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57781/#review169475
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On March 20, 2017, 12:13 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57781/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 12:13 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-20502
> https://issues.apache.org/jira/browse/AMBARI-20502
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some markdown displays, like GitHub, don't properly display the configuration markdown. Sections appear as:
>
> {code}
> ####Alerts & Notifications | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | alerts.execution.scheduler.threadpool.size.core | 2 | 2 | 4 | 4 | | alerts.execution.scheduler.threadpool.size.max | 2 | 2 | 8 | 8 | | alerts.execution.scheduler.threadpool.worker.size | 400 | 2000 | 4000 | 20000 | | alerts.cache.enabled | false | false | false | true | | alerts.cache.flush.interval | 10 | 10 | 10 | 10 | | alerts.cache.size | 50000 | 50000 | 100000 | 100000 | ####Jetty API & Agent Thread Pools | Property Name | 10 Hosts | ~50 Hosts | ~100 Hosts | 500+ Hosts | | --- | --- | --- | --- | --- | | client.threadpool.size.max | 25 | 35 | 50 | 65 | | agent.threadpool.size.max | 25 | 35 | 75 | 100 |
> {code}
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 7a7f3b9
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 20431f6
>
>
> Diff: https://reviews.apache.org/r/57781/diff/1/
>
>
> Testing
> -------
>
> Created a feature branch on Github to test this change. Verified that the Markdown has been corrected.
>
>
> Thanks,
>
> Jonathan Hurley
>
>