You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2018/09/15 16:59:52 UTC
httpcomponents-client git commit: Make HC Client beta SNAPSHOT
depends on HC Core beta SNAPSHOT. Avoids current runtime mismatch with
HttpContext,
which happens if you want to depend on SNAPSHOTs of both components.
Repository: httpcomponents-client
Updated Branches:
refs/heads/master 7f3539c18 -> f30fa6d54
Make HC Client beta SNAPSHOT depends on HC Core beta SNAPSHOT. Avoids
current runtime mismatch with HttpContext, which happens if you want to
depend on SNAPSHOTs of both components.
Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/commit/f30fa6d5
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/tree/f30fa6d5
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/diff/f30fa6d5
Branch: refs/heads/master
Commit: f30fa6d54920036fd1d63e464d05d5787a5b9256
Parents: 7f3539c
Author: Gary Gregory <gg...@rocketsoftware.com>
Authored: Sat Sep 15 10:59:49 2018 -0600
Committer: Gary Gregory <gg...@rocketsoftware.com>
Committed: Sat Sep 15 10:59:49 2018 -0600
----------------------------------------------------------------------
.../hc/client5/http/impl/async/MinimalHttpAsyncClient.java | 5 +++++
pom.xml | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/f30fa6d5/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/MinimalHttpAsyncClient.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/MinimalHttpAsyncClient.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/MinimalHttpAsyncClient.java
index 3f473a3..c88469f 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/MinimalHttpAsyncClient.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/MinimalHttpAsyncClient.java
@@ -404,6 +404,11 @@ public final class MinimalHttpAsyncClient extends AbstractMinimalHttpAsyncClient
this.released = new AtomicBoolean(false);
}
+ @Override
+ public boolean isConnected() {
+ return connectionEndpoint.isConnected();
+ }
+
boolean isReleased() {
return released.get();
}
http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/f30fa6d5/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 7c9eded..97b4723 100644
--- a/pom.xml
+++ b/pom.xml
@@ -68,7 +68,7 @@
<properties>
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
- <httpcore.version>5.0-beta3</httpcore.version>
+ <httpcore.version>5.0-beta4-SNAPSHOT</httpcore.version>
<log4j.version>2.9.1</log4j.version>
<commons-codec.version>1.11</commons-codec.version>
<ehcache.version>3.4.0</ehcache.version>
Re: httpcomponents-client git commit: Make HC Client beta SNAPSHOT
depends on HC Core beta SNAPSHOT. Avoids current runtime mismatch with
HttpContext, which happens if you want to depend on SNAPSHOTs of both components.
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Sep 15, 2018 at 11:45 AM Oleg Kalnichevski <ol...@apache.org> wrote:
> On Sat, 2018-09-15 at 16:59 +0000, ggregory@apache.org wrote:
> > Repository: httpcomponents-client
> > Updated Branches:
> > refs/heads/master 7f3539c18 -> f30fa6d54
> >
> >
> > Make HC Client beta SNAPSHOT depends on HC Core beta SNAPSHOT. Avoids
> > current runtime mismatch with HttpContext, which happens if you want
> > to
> > depend on SNAPSHOTs of both components.
> >
>
> Why? What about those who do not want to depend on SNAPSHOTs of both
> components?
>
It's a catch-22 ATM. Without this change, if an app depends on
HC-Core-Snap, it cannot use HC-Client.
Gary
>
> Oleg
>
>
Re: httpcomponents-client git commit: Make HC Client beta SNAPSHOT
depends on HC Core beta SNAPSHOT. Avoids current runtime mismatch with
HttpContext, which happens if you want to depend on SNAPSHOTs of both
components.
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sat, 2018-09-15 at 16:59 +0000, ggregory@apache.org wrote:
> Repository: httpcomponents-client
> Updated Branches:
> refs/heads/master 7f3539c18 -> f30fa6d54
>
>
> Make HC Client beta SNAPSHOT depends on HC Core beta SNAPSHOT. Avoids
> current runtime mismatch with HttpContext, which happens if you want
> to
> depend on SNAPSHOTs of both components.
>
Why? What about those who do not want to depend on SNAPSHOTs of both
components?
Oleg
Re: httpcomponents-client git commit: Make HC Client beta SNAPSHOT
depends on HC Core beta SNAPSHOT. Avoids current runtime mismatch with
HttpContext, which happens if you want to depend on SNAPSHOTs of both
components.
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sat, 2018-09-15 at 16:59 +0000, ggregory@apache.org wrote:
> Repository: httpcomponents-client
> Updated Branches:
> refs/heads/master 7f3539c18 -> f30fa6d54
>
>
> Make HC Client beta SNAPSHOT depends on HC Core beta SNAPSHOT. Avoids
> current runtime mismatch with HttpContext, which happens if you want
> to
> depend on SNAPSHOTs of both components.
>
Why? What about those who do not want to depend on SNAPSHOTs of both
components?
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org