[jira] [Commented] (CASSANDRA-14319) nodetool rebuild from DC lets you pass invalid datacenters

["Benjamin Lerer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389742#comment-17389742 ] 

Benjamin Lerer commented on CASSANDRA-14319:
--------------------------------------------

The fix looks good to me. I think it would be good to have some test to verify the behavior. 
[~vinaykumarcse] could you add a test to your patch? 

> nodetool rebuild from DC lets you pass invalid datacenters 
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-14319
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14319
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/nodetool
>            Reporter: Jon Haddad
>            Assignee: Vinay Chella
>            Priority: Normal
>             Fix For: 2.1.x, 2.2.x, 3.0.x, 3.11.x, 4.x
>
>         Attachments: CASSANDRA-14319-trunk.txt
>
>
> If you pass an invalid datacenter to nodetool rebuild, you'll get an error like this:
> {code}
> Unable to find sufficient sources for streaming range (3074457345618258602,-9223372036854775808] in keyspace system_distributed
> {code}
> Unfortunately, this is a rabbit hole of frustration if you are using caps for your DC names and you pass in a lowercase DC name, or you just typo the DC.  
> Let's do the following:
> # Check the DC name that's passed in against the list of DCs we know about
> # If we don't find it, let's output a reasonable error, and list all the DCs someone could put in.
> # Ideally we indicate which keyspaces are set to replicate to this DC and which aren't



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org