Re: [PR] Attempt to coerce COMPLEX to number in numeric aggregators. (druid)

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on code in PR #16564:
URL: https://github.com/apache/druid/pull/16564#discussion_r1690282781


##########
extensions-contrib/spectator-histogram/src/main/java/org/apache/druid/spectator/histogram/SpectatorHistogramIndexBasedComplexColumn.java:
##########
@@ -59,72 +53,11 @@ public Object getRowValue(int rowNum)
   @Override
   public int getLength()
   {
-    return index.size();
+    return -1;

Review Comment:
   The method is specced as returning the serialized size of the column in bytes, or -1 if unknown. `index.size()` returns a row count, which doesn't match the specced behavior. The `SpectatorHistogramIndexed` doesn't seem to know its own serialized size, and the `getLength()` method doesn't seem to be used anywhere important, so I figured changing this to -1 was a good idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org