You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/07/01 15:20:40 UTC

[GitHub] [submarine] manirajv06 commented on a change in pull request #299: SUBMARINE-507. Submarine Environment Management

manirajv06 commented on a change in pull request #299:
URL: https://github.com/apache/submarine/pull/299#discussion_r448438427



##########
File path: submarine-server/server-api/src/main/java/org/apache/submarine/server/api/spec/Environment.java
##########
@@ -20,18 +20,43 @@
 package org.apache.submarine.server.api.spec;
 
 public class Environment {
-  private String image;
-
+  
+  /**
+   * ID of the environment
+   */
+  private int environmentId;
+  
   /**
-   * Get the image for the experiment. If the {@link ExperimentTaskSpec#getImage()} not
-   * specified the image replaced with it.
-   * @return image
+   * Name of the environment
    */

Review comment:
       Taken care. Class itself is redundant, so removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org