You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/21 02:37:23 UTC
[GitHub] [cordova-android] erisu opened a new pull request #904: fix (adb):
shell to return expected stdout
erisu opened a new pull request #904: fix (adb): shell to return expected stdout
URL: https://github.com/apache/cordova-android/pull/904
### Motivation and Context
Fix error when executing `cordova run android` to launch on emulator.
### Description
When executing `cordova run android` to launch the app on an emulator, the Adb shell is not returning the expected stdout and results in an error `output.match is not a function`.
### Testing
- `npm t`
- `cordova run android`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #904: fix (adb): shell
to return expected stdout
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #904: fix (adb): shell to return expected stdout
URL: https://github.com/apache/cordova-android/pull/904
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on issue #904: fix (adb):
shell to return expected stdout
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #904: fix (adb): shell to return expected stdout
URL: https://github.com/apache/cordova-android/pull/904#issuecomment-576495522
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=h1) Report
> Merging [#904](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/64ef13c6e0a6916686501736d5bd388b208be860?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
+ Coverage 66.17% 66.19% +0.01%
==========================================
Files 19 19
Lines 1839 1840 +1
==========================================
+ Hits 1217 1218 +1
Misses 622 622
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/904/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=footer). Last update [64ef13c...1b676c8](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #904: fix
(adb): shell to return expected stdout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #904: fix (adb): shell to return expected stdout
URL: https://github.com/apache/cordova-android/pull/904#issuecomment-576495522
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=h1) Report
> Merging [#904](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/64ef13c6e0a6916686501736d5bd388b208be860?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
+ Coverage 66.17% 66.19% +0.01%
==========================================
Files 19 19
Lines 1839 1840 +1
==========================================
+ Hits 1217 1218 +1
Misses 622 622
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/904/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=footer). Last update [64ef13c...1b676c8](https://codecov.io/gh/apache/cordova-android/pull/904?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org